Issue 9038043: code review 9038043: cmd/ld: disable relocation range check so build can go ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9038043: code review 9038043: cmd/ld: disable relocation range check so build can go ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by r

Modified:
11 years, 8 months ago

Reviewers:
dsymonds

CC:
golang-dev, dsymonds, dave_cheney.net

Visibility:
Public.

Description

cmd/ld: disable relocation range check so build can go green while we debug the issue.

Patch Set 1 #

Patch Set 2 : diff -r 587ffbeec2f5 https://code.google.com/p/go/ #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	src/cmd/ld/data.c	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

11 years, 10 months ago (2013-04-30 07:17:05 UTC) #1

dave_cheney.net

On 2013/04/30 07:17:43, dsymonds wrote: > LGTM Thanks r, testing on some arm machines now.

11 years, 10 months ago (2013-04-30 07:18:59 UTC) #3

11 years, 10 months ago (2013-04-30 07:19:26 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=a1c663e7a303 ***

cmd/ld: disable relocation range check so build can go green while we debug the
issue.

R=golang-dev, dsymonds, dave
CC=golang-dev
https://codereview.appspot.com/9038043

Expand All Messages | Collapse All Messages