Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1375)

Issue 9035045: Added tests to new model controller

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by jeff.pihach
Modified:
9 years, 7 months ago
Reviewers:
mp+161693, bac, gary.poster
Visibility:
Public.

Description

Added tests to new model controller https://code.launchpad.net/~hatch/juju-gui/model-control-tests/+merge/161693 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 8

Patch Set 2 : Added tests to new model controller #

Total comments: 1

Patch Set 3 : Added tests to new model controller #

Unified diffs Side-by-side diffs Delta from patch set Stats (+237 lines, -3 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M app/models/model-controller.js View 1 chunk +2 lines, -2 lines 0 comments Download
M app/store/endpoints.js View 1 chunk +2 lines, -1 line 0 comments Download
M test/index.html View 1 chunk +2 lines, -0 lines 0 comments Download
A test/test_model_controller.js View 1 1 chunk +229 lines, -0 lines 0 comments Download

Messages

Total messages: 7
jeff.pihach
Please take a look.
9 years, 7 months ago (2013-04-30 20:21:29 UTC) #1
gary.poster
You could add a test for the failure path in getServiceWithCharm, and that would be ...
9 years, 7 months ago (2013-04-30 21:03:46 UTC) #2
jeff.pihach
Thanks for the review! As mentioned in IRC the clobbering is only happening on certain ...
9 years, 7 months ago (2013-04-30 21:23:18 UTC) #3
jeff.pihach
Please take a look.
9 years, 7 months ago (2013-04-30 21:28:57 UTC) #4
gary.poster
LEBTM: Looks even better to me ;-)
9 years, 7 months ago (2013-05-01 13:01:41 UTC) #5
bac
LGTM with one requested change. Really like your cleanup approach. https://codereview.appspot.com/9035045/diff/6001/test/test_model_controller.js File test/test_model_controller.js (right): https://codereview.appspot.com/9035045/diff/6001/test/test_model_controller.js#newcode135 ...
9 years, 7 months ago (2013-05-01 14:08:36 UTC) #6
jeff.pihach
9 years, 7 months ago (2013-05-01 19:43:13 UTC) #7
*** Submitted:

Added tests to new model controller

R=
CC=
https://codereview.appspot.com/9035045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b