code review 9033048: cmd/gc: fix race instrumentation of selectors T(v).Field

cmd/gc: fix race instrumentation of selectors T(v).Field

Fixes issue 5424.

[remyoudompheng, 2013-05-08 11:41:50]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[DMorsing, 2013-05-09 08:09:31]

LGTM

https://codereview.appspot.com/9033048/diff/5001/src/cmd/gc/racewalk.c
File src/cmd/gc/racewalk.c (right):

https://codereview.appspot.com/9033048/diff/5001/src/cmd/gc/racewalk.c#newcod...
src/cmd/gc/racewalk.c:502: makeaddable(Node *n)
Small note here about why the {cheap,local,safe}expr functions in subr.c wont
work (they make a copy variable with a new address).

https://codereview.appspot.com/9033048/diff/5001/src/pkg/runtime/race/testdat...
File src/pkg/runtime/race/testdata/comp_test.go (right):

https://codereview.appspot.com/9033048/diff/5001/src/pkg/runtime/race/testdat...
src/pkg/runtime/race/testdata/comp_test.go:86: type Π P
Please keep these identifiers ASCII only for those of us without an APL
typeball.

[dvyukov, 2013-05-12 11:57:30]

LGTM
Thanks!

https://codereview.appspot.com/9033048/diff/5001/src/pkg/runtime/race/testdat...
File src/pkg/runtime/race/testdata/comp_test.go (right):

https://codereview.appspot.com/9033048/diff/5001/src/pkg/runtime/race/testdat...
src/pkg/runtime/race/testdata/comp_test.go:86: type Π P
On 2013/05/09 08:09:31, DMorsing wrote:
> Please keep these identifiers ASCII only for those of us without an APL
> typeball.

Yes, please. Unicode symbols break some text editors.

[remyoudompheng, 2013-05-12 12:07:27]

Is this for Go 1.1? (By the way, is the commit freeze still in effect now that
we have release-branch.go1.1)

https://codereview.appspot.com/9033048/diff/5001/src/cmd/gc/racewalk.c
File src/cmd/gc/racewalk.c (right):

https://codereview.appspot.com/9033048/diff/5001/src/cmd/gc/racewalk.c#newcod...
src/cmd/gc/racewalk.c:502: makeaddable(Node *n)
On 2013/05/09 08:09:31, DMorsing wrote:
> Small note here about why the {cheap,local,safe}expr functions in subr.c wont
> work (they make a copy variable with a new address).

Done.

https://codereview.appspot.com/9033048/diff/5001/src/pkg/runtime/race/testdat...
File src/pkg/runtime/race/testdata/comp_test.go (right):

https://codereview.appspot.com/9033048/diff/5001/src/pkg/runtime/race/testdat...
src/pkg/runtime/race/testdata/comp_test.go:86: type Π P
On 2013/05/12 11:57:30, dvyukov wrote:
> On 2013/05/09 08:09:31, DMorsing wrote:
> > Please keep these identifiers ASCII only for those of us without an APL
> > typeball.
> 
> Yes, please. Unicode symbols break some text editors.

Done.

[r, 2013-05-12 15:01:03]

Yes, for a little longer please hold off submitting without approval
from me or adg.

Regarding Unicode: I think it's fine to use a little when it makes
sense - at this point in the evolution of technology we shouldn't be
worried about editors that can't handle it - but I don't understand
why this CL uses so much of it.

-rob

[remyoudompheng, 2013-05-14 23:14:18]

is it OK now?

[r, 2013-05-14 23:14:45]

LGTM

yes, the floodgates are open.

[remyoudompheng, 2013-05-14 23:25:42]

*** Submitted as https://code.google.com/p/go/source/detail?r=8223559e536b ***

cmd/gc: fix race instrumentation of selectors T(v).Field

Fixes issue 5424.

R=golang-dev, daniel.morsing, dvyukov, r
CC=golang-dev
https://codereview.appspot.com/9033048