Moin2.0 : IOError while testing with py.test updated as per the requirement

Moin2.0 : IOError while testing with py.test updated as per the requirement

please view the file test_interwiki.py 

IOError fixed: 
1) The program takes the current working directory.

2) Split them with delimiter '/' to make up a list.

3) Now with each directory in the list of directories made by os.getcwd(). It looks out for '.hg' folder which signifies the repository at the very first occurence it takes the directory where it is searched.

4) This will be the path required.

[Thomas.J.Waldmann, 2013-05-10 16:49:41]

btw, i recently started some StringIO work, see the issue tracker for more
infos.

https://codereview.appspot.com/9027045/diff/1/MoinMoin/_tests/__init__.py
File MoinMoin/_tests/__init__.py (right):

https://codereview.appspot.com/9027045/diff/1/MoinMoin/_tests/__init__.py#new...
MoinMoin/_tests/__init__.py:15: from io import StringIO
no.

io is available on python 2.7 also.
but: using this is often much more than just replacing the import, because it is
much more strict and ONLY accepts unicode.

https://codereview.appspot.com/9027045/diff/1/MoinMoin/util/_tests/test_inter...
File MoinMoin/util/_tests/test_interwiki.py (right):

https://codereview.appspot.com/9027045/diff/1/MoinMoin/util/_tests/test_inter...
MoinMoin/util/_tests/test_interwiki.py:199: break
i have no idea what you are trying to do here, but it seems complicated and
wrong.

https://codereview.appspot.com/9027045/diff/1/MoinMoin/util/_tests/test_inter...
MoinMoin/util/_tests/test_interwiki.py:205: #testfile =
os.path.join(abspath,'2.0','contrib', 'interwiki', 'intermap.txt')
why do you keep these 2 lines?

use revision control, not comments.

[chitrankdixit, 2013-05-10 17:15:50]

https://codereview.appspot.com/9027045/diff/1/MoinMoin/_tests/__init__.py
File MoinMoin/_tests/__init__.py (right):

https://codereview.appspot.com/9027045/diff/1/MoinMoin/_tests/__init__.py#new...
MoinMoin/_tests/__init__.py:15: from io import StringIO
So what else could be done. I though this could be one of the simple yet good
fix for this test (for python2.7 and python3.3) but if something else need to be
done Please let me know I would fix it up.



On 2013/05/10 16:49:41, Thomas.J.Waldmann wrote:
> no.
> 
> io is available on python 2.7 also.
> but: using this is often much more than just replacing the import, because it
is
> much more strict and ONLY accepts unicode.

https://codereview.appspot.com/9027045/diff/1/MoinMoin/util/_tests/test_inter...
File MoinMoin/util/_tests/test_interwiki.py (right):

https://codereview.appspot.com/9027045/diff/1/MoinMoin/util/_tests/test_inter...
MoinMoin/util/_tests/test_interwiki.py:205: #testfile =
os.path.join(abspath,'2.0','contrib', 'interwiki', 'intermap.txt')
Sorry for the comments here

On 2013/05/10 16:49:41, Thomas.J.Waldmann wrote:
> why do you keep these 2 lines?
> 
> use revision control, not comments.

[chitrankdixit, 2013-05-10 17:38:51]

https://codereview.appspot.com/9027045/diff/1/MoinMoin/util/_tests/test_inter...
File MoinMoin/util/_tests/test_interwiki.py (right):

https://codereview.appspot.com/9027045/diff/1/MoinMoin/util/_tests/test_inter...
MoinMoin/util/_tests/test_interwiki.py:199: break
After using the original code(marked red) snipped the path that should come is:
Actual Path:
/home/chitrank/Documents/Google_Summer_of_code/MoinMoinwiki/2.0/contrib/interwiki/intermap.txt

but method .rsplit split the path as 'MoinMoin' delimiter
(developers have tested the path with only one occurence of MoinMoin but here I
have two occurences of MoinMoin in my path).
One occurence split the path into two parts whereas Two occurence split the path
into three parts. which creates the problem of unknown path.

Error Path:
/home/chitrank/Documents/Google_Summer_of_code/contrib/interwiki/intermap.txt

So here rsplit makes three elements of path (developers might have tested for
two elements) and the path at index [0] is assigned to abspath variable 
and this abspath is join in the below line which is assigned to testfile.


On 2013/05/10 16:49:41, Thomas.J.Waldmann wrote:
> i have no idea what you are trying to do here, but it seems complicated and
> wrong.

https://codereview.appspot.com/9027045/diff/1/MoinMoin/util/_tests/test_inter...
MoinMoin/util/_tests/test_interwiki.py:199: break
Actual Path to come after running code snipped (marked red):
/home/chitrank/Documents/Google_Summer_of_code/MoinMoinwiki/2.0/contrib/interwiki/intermap.txt

But this Error path comes:
/home/chitrank/Documents/Google_Summer_of_code/contrib/interwiki/intermap.txt

The Error path comes due to Two occurences of MoinMoin in my path rather than
one(that might have tested by moin developers before).

Now my code above takes the current path and make up a list by splitting using
'/' this list contains all the path from root level to the local directory the
file is reciding in.
each element is taken and the list of directories associated with that element
is checked if element would be repository folder of Moin then it gets '.hg'
folder and delimit from that this element is stored in path variable and then
the loop halts.

On 2013/05/10 16:49:41, Thomas.J.Waldmann wrote:
> i have no idea what you are trying to do here, but it seems complicated and
> wrong.

[Thomas.J.Waldmann, 2013-05-10 18:11:50]

https://codereview.appspot.com/9027045/diff/1/MoinMoin/_tests/__init__.py
File MoinMoin/_tests/__init__.py (right):

https://codereview.appspot.com/9027045/diff/1/MoinMoin/_tests/__init__.py#new...
MoinMoin/_tests/__init__.py:15: from io import StringIO
see the patch and issue i submitted to the issue tracker.

https://codereview.appspot.com/9027045/diff/1/MoinMoin/util/_tests/test_inter...
File MoinMoin/util/_tests/test_interwiki.py (right):

https://codereview.appspot.com/9027045/diff/1/MoinMoin/util/_tests/test_inter...
MoinMoin/util/_tests/test_interwiki.py:199: break
the cwd has nothing to do with what you need to do here, it could be anywhere.
especially, the cwd has nothing to do with where the current code file is, this
is what __file__ is for.

also, using .hg is completely weird for this purpose.

how about first thinking about what you NEED to do and getting a clear
understanding of it and then looking for a good way to do it in python? i
suggest you write that goal first in clear and precise english before trying
python.

[chitrankdixit, 2013-05-10 18:26:44]

Okay Thomas I should traceback myself why does the error occurs in my system and
understand more about the code written. 

Thanks for the precious suggestions.