Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(95)

Issue 90230043: PS broadcast commment fix

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years ago by prannoysircar0325
Modified:
10 years ago
Reviewers:
mail2coolgarg
CC:
dev_shoppoke.com
Base URL:
https://immpandroid.unfuddle.com/svn/immpandroid_android/
Visibility:
Public.

Description

PS broadcast commment fix

Patch Set 1 #

Total comments: 7
Unified diffs Side-by-side diffs Delta from patch set Stats (+220 lines, -7 lines) Patch
M spfaq/.classpath View 1 chunk +1 line, -0 lines 0 comments Download
M spfaq/AndroidManifest.xml View 2 chunks +16 lines, -0 lines 0 comments Download
M spfaq/project.properties View 1 chunk +2 lines, -2 lines 0 comments Download
M spfaq/res/values/strings.xml View 2 chunks +2 lines, -1 line 0 comments Download
M spfaq/src/app/shoppoke/faq/activities/dashboard/Dashboard2Activity.java View 1 chunk +1 line, -0 lines 0 comments Download
M spfaq/src/app/shoppoke/faq/qa/StorePhone.java View 2 chunks +7 lines, -2 lines 2 comments Download
A spfaq/src/app/shoppoke/faq/receiver/PhoneCallReceiver.java View 1 chunk +59 lines, -0 lines 1 comment Download
A spfaq/src/app/shoppoke/faq/receiver/SmsPhoneReceiverHandler.java View 1 chunk +74 lines, -0 lines 3 comments Download
A spfaq/src/app/shoppoke/faq/receiver/SmsReceiver.java View 1 chunk +57 lines, -0 lines 1 comment Download
M spfaq/src/app/shoppoke/faq/storedetail/PopularQuestionHandler.java View 1 chunk +0 lines, -2 lines 0 comments Download
M spfaq/src/app/shoppoke/faq/storedetail/StoreDetailActivity.java View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 1
mail2coolgarg
10 years ago (2014-04-22 12:05:09 UTC) #1
fix comments. and send again.

https://codereview.appspot.com/90230043/diff/1/spfaq/src/app/shoppoke/faq/qa/...
File spfaq/src/app/shoppoke/faq/qa/StorePhone.java (right):

https://codereview.appspot.com/90230043/diff/1/spfaq/src/app/shoppoke/faq/qa/...
spfaq/src/app/shoppoke/faq/qa/StorePhone.java:80: public static List<StorePhone>
getDepartment(Context activity,
getDepartment name does not make any sense.

https://codereview.appspot.com/90230043/diff/1/spfaq/src/app/shoppoke/faq/qa/...
spfaq/src/app/shoppoke/faq/qa/StorePhone.java:80: public static List<StorePhone>
getDepartment(Context activity,
it should return only one store. first store in the list.

https://codereview.appspot.com/90230043/diff/1/spfaq/src/app/shoppoke/faq/rec...
File spfaq/src/app/shoppoke/faq/receiver/PhoneCallReceiver.java (right):

https://codereview.appspot.com/90230043/diff/1/spfaq/src/app/shoppoke/faq/rec...
spfaq/src/app/shoppoke/faq/receiver/PhoneCallReceiver.java:48: incomingNumber);
change accordingly.

https://codereview.appspot.com/90230043/diff/1/spfaq/src/app/shoppoke/faq/rec...
File spfaq/src/app/shoppoke/faq/receiver/SmsPhoneReceiverHandler.java (right):

https://codereview.appspot.com/90230043/diff/1/spfaq/src/app/shoppoke/faq/rec...
spfaq/src/app/shoppoke/faq/receiver/SmsPhoneReceiverHandler.java:40: if (storeId
> 0) {
no need to fetch storeId, just check item != null..

https://codereview.appspot.com/90230043/diff/1/spfaq/src/app/shoppoke/faq/rec...
spfaq/src/app/shoppoke/faq/receiver/SmsPhoneReceiverHandler.java:49:
StoreResponseObject sro = StoreResponseObject.getStoreDBUtil(
item is sro. no need to make a db query.

https://codereview.appspot.com/90230043/diff/1/spfaq/src/app/shoppoke/faq/rec...
spfaq/src/app/shoppoke/faq/receiver/SmsPhoneReceiverHandler.java:51: if (sro ==
null) {
remove these toasts.

https://codereview.appspot.com/90230043/diff/1/spfaq/src/app/shoppoke/faq/rec...
File spfaq/src/app/shoppoke/faq/receiver/SmsReceiver.java (right):

https://codereview.appspot.com/90230043/diff/1/spfaq/src/app/shoppoke/faq/rec...
spfaq/src/app/shoppoke/faq/receiver/SmsReceiver.java:48: List<StorePhone>
localContactList = new ArrayList<StorePhone>();
why are you doing this thing? fetching storephones. no need to do this.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b