Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(235)

Issue 90190044: code review 90190044: cmd/dist: permit go* tag in main branch when it include... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by adg
Modified:
11 years ago
Reviewers:
dave, rsc
CC:
rsc, golang-codereviews
Visibility:
Public.

Description

cmd/dist: permit go* tag in main branch when it includes "beta" This change allows us to give an hg tag such as "go1.3beta1" to revisions in the main branch without breaking the build. This is helpful for community members who want to build the beta from source.

Patch Set 1 #

Patch Set 2 : diff -r a9d4ac7d62b9 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/cmd/dist/build.c View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
adg
Hello rsc (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
11 years ago (2014-04-23 20:46:07 UTC) #1
rsc
LGTM
11 years ago (2014-05-01 16:12:30 UTC) #2
adg
*** Submitted as https://code.google.com/p/go/source/detail?r=908dc7fc8446 *** cmd/dist: permit go* tag in main branch when it includes ...
11 years ago (2014-05-01 16:13:35 UTC) #3
dave_cheney.net
11 years ago (2014-05-01 17:06:30 UTC) #4
LGTM. Thank you

On Fri, May 2, 2014 at 2:13 AM,  <adg@golang.org> wrote:
> *** Submitted as
> https://code.google.com/p/go/source/detail?r=908dc7fc8446 ***
>
> cmd/dist: permit go* tag in main branch when it includes "beta"
>
> This change allows us to give an hg tag such as "go1.3beta1" to
> revisions in the main branch without breaking the build.
>
> This is helpful for community members who want to build the beta
> from source.
>
> LGTM=rsc
> R=rsc
> CC=golang-codereviews
> https://codereview.appspot.com/90190044
>
>
>
> https://codereview.appspot.com/90190044/
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b