PS broadcast sms n phone call with api (for time being hit goes for only storeid 7-cleartrip)

PS broadcast sms n phone call with api (for time being hit goes for only storeid 7-cleartrip)

[mail2coolgarg, 2014-04-22 06:38:32]

please fix comments. and send for code review again

https://codereview.appspot.com/90160043/diff/1/spfaq/AndroidManifest.xml
File spfaq/AndroidManifest.xml (right):

https://codereview.appspot.com/90160043/diff/1/spfaq/AndroidManifest.xml#newc...
spfaq/AndroidManifest.xml:57: <uses-permission
android:name="android.permission.SEND_SMS" >
we might not require SEND_SMS permission.

https://codereview.appspot.com/90160043/diff/1/spfaq/src/app/shoppoke/faq/act...
File spfaq/src/app/shoppoke/faq/activities/base/BaseApp.java (right):

https://codereview.appspot.com/90160043/diff/1/spfaq/src/app/shoppoke/faq/act...
spfaq/src/app/shoppoke/faq/activities/base/BaseApp.java:10: 
if there is no change in this class, then revert it back.

https://codereview.appspot.com/90160043/diff/1/spfaq/src/app/shoppoke/faq/act...
File spfaq/src/app/shoppoke/faq/activities/base/HttpRequestTask.java (right):

https://codereview.appspot.com/90160043/diff/1/spfaq/src/app/shoppoke/faq/act...
spfaq/src/app/shoppoke/faq/activities/base/HttpRequestTask.java:61: 
in above constructor change Activity parameter to Context. no need for new
constructor.

https://codereview.appspot.com/90160043/diff/1/spfaq/src/app/shoppoke/faq/rec...
File spfaq/src/app/shoppoke/faq/receiver/PhoneCallReceiver.java (right):

https://codereview.appspot.com/90160043/diff/1/spfaq/src/app/shoppoke/faq/rec...
spfaq/src/app/shoppoke/faq/receiver/PhoneCallReceiver.java:20:
MyPhoneStateListener PhoneListener = new MyPhoneStateListener(
camelcase it, phoneListner.

format it well,remove unnecessary comments.

https://codereview.appspot.com/90160043/diff/1/spfaq/src/app/shoppoke/faq/rec...
spfaq/src/app/shoppoke/faq/receiver/PhoneCallReceiver.java:40:
smsPhoneReceiverHandler = new SmsPhoneReceiverHandler(pcontext);
don't use SmsPhoneReceiverHandler int that, you need to check if the calling
number is stored in local database. and based on that you need to invoke
notification.

https://codereview.appspot.com/90160043/diff/1/spfaq/src/app/shoppoke/faq/rec...
spfaq/src/app/shoppoke/faq/receiver/PhoneCallReceiver.java:43: public void
onCallStateChanged(int state, String incomingNumber) {
format if properly.

https://codereview.appspot.com/90160043/diff/1/spfaq/src/app/shoppoke/faq/rec...
File spfaq/src/app/shoppoke/faq/receiver/SmsPhoneReceiverHandler.java (right):

https://codereview.appspot.com/90160043/diff/1/spfaq/src/app/shoppoke/faq/rec...
spfaq/src/app/shoppoke/faq/receiver/SmsPhoneReceiverHandler.java:20:
ResponseParserListener<SmsPhoneResponseObject> {
Remove SmsPhoneResponseObject class, instead of that use StoreResponseObject,
ask naman to do the corresponding change at backend also.

https://codereview.appspot.com/90160043/diff/1/spfaq/src/app/shoppoke/faq/rec...
spfaq/src/app/shoppoke/faq/receiver/SmsPhoneReceiverHandler.java:41: if (storeId
== 7) {
make a condition the storeId > 0

https://codereview.appspot.com/90160043/diff/1/spfaq/src/app/shoppoke/faq/rec...
spfaq/src/app/shoppoke/faq/receiver/SmsPhoneReceiverHandler.java:45:
.setContentTitle("Read FAQs of " + " " + "ClearTrip")
dont hardcode Cleartrip, use item.name

https://codereview.appspot.com/90160043/diff/1/spfaq/src/app/shoppoke/faq/rec...
spfaq/src/app/shoppoke/faq/receiver/SmsPhoneReceiverHandler.java:58:
sro.update(context);
update logic should not be here.

https://codereview.appspot.com/90160043/diff/1/spfaq/src/app/shoppoke/faq/rec...
File spfaq/src/app/shoppoke/faq/receiver/SmsPhoneResponseObject.java (right):

https://codereview.appspot.com/90160043/diff/1/spfaq/src/app/shoppoke/faq/rec...
spfaq/src/app/shoppoke/faq/receiver/SmsPhoneResponseObject.java:8: 
this class not needed, use StoreResponseObject.

https://codereview.appspot.com/90160043/diff/1/spfaq/src/app/shoppoke/faq/rec...
File spfaq/src/app/shoppoke/faq/receiver/SmsReceiver.java (right):

https://codereview.appspot.com/90160043/diff/1/spfaq/src/app/shoppoke/faq/rec...
spfaq/src/app/shoppoke/faq/receiver/SmsReceiver.java:43: for (int i = 0; i <
pdusObj.length; i++) {
this logic is bit fishy, because it will over write phonenumber everytime. so
only last one will be sent over api. just check it, we need latest sms only,
which is received.

https://codereview.appspot.com/90160043/diff/1/spfaq/src/app/shoppoke/faq/rec...
spfaq/src/app/shoppoke/faq/receiver/SmsReceiver.java:49: String senderNum =
phoneNumber;
declaring senderNum is unncessary. use phoneNumber only.

https://codereview.appspot.com/90160043/diff/1/spfaq/src/app/shoppoke/faq/rec...
spfaq/src/app/shoppoke/faq/receiver/SmsReceiver.java:54: Toast toast =
Toast.makeText(context, "senderNum: "
dont display toasts.