Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(239)

Issue 90080043: code review 90080043: math/big: fix Int.Exp (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 7 months ago by gri
Modified:
7 years, 7 months ago
Reviewers:
agl1, agl, adonovan
CC:
golang-codereviews
Visibility:
Public.

Description

math/big: fix Int.Exp Fixes issue 7814.

Patch Set 1 #

Patch Set 2 : diff -r c313673339c4 https://code.google.com/p/go/ #

Patch Set 3 : diff -r c313673339c4 https://code.google.com/p/go/ #

Patch Set 4 : diff -r c313673339c4 https://code.google.com/p/go/ #

Patch Set 5 : diff -r c313673339c4 https://code.google.com/p/go/ #

Total comments: 2

Patch Set 6 : diff -r c313673339c4 https://code.google.com/p/go/ #

Patch Set 7 : diff -r c313673339c4 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -10 lines) Patch
M src/pkg/math/big/int.go View 1 2 3 4 1 chunk +7 lines, -6 lines 0 comments Download
M src/pkg/math/big/int_test.go View 1 2 3 4 5 1 chunk +13 lines, -0 lines 0 comments Download
M src/pkg/math/big/nat.go View 1 1 chunk +8 lines, -3 lines 0 comments Download
M src/pkg/math/big/nat_test.go View 1 2 3 4 5 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 8
gri
Hello agl@chromium.org, adonovan@google.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
7 years, 7 months ago (2014-04-21 22:33:40 UTC) #1
gri
agl: Should the result of Exp(x, y, m) always be 1 for y <= 0 ...
7 years, 7 months ago (2014-04-21 22:35:44 UTC) #2
agl1
LGTM
7 years, 7 months ago (2014-04-21 22:35:48 UTC) #3
agl
On Mon, Apr 21, 2014 at 3:35 PM, Robert Griesemer <gri@golang.org> wrote: > agl: Should ...
7 years, 7 months ago (2014-04-21 22:39:03 UTC) #4
gri
Hello agl@chromium.org, adonovan@google.com, agl@golang.org (cc: golang-codereviews@googlegroups.com), Please take another look.
7 years, 7 months ago (2014-04-21 22:47:48 UTC) #5
adonovan
LGTM https://codereview.appspot.com/90080043/diff/80001/src/pkg/math/big/int_test.go File src/pkg/math/big/int_test.go (right): https://codereview.appspot.com/90080043/diff/80001/src/pkg/math/big/int_test.go#newcode777 src/pkg/math/big/int_test.go:777: {"1", "0", "1", "0"}, Can you also test ...
7 years, 7 months ago (2014-04-21 22:50:39 UTC) #6
gri
*** Submitted as https://code.google.com/p/go/source/detail?r=7b060a00329e *** math/big: fix Int.Exp Fixes issue 7814. LGTM=agl, adonovan R=agl, adonovan ...
7 years, 7 months ago (2014-04-21 22:54:49 UTC) #7
gri
7 years, 7 months ago (2014-04-21 22:54:53 UTC) #8
Message was sent while issue was closed.
https://codereview.appspot.com/90080043/diff/80001/src/pkg/math/big/int_test.go
File src/pkg/math/big/int_test.go (right):

https://codereview.appspot.com/90080043/diff/80001/src/pkg/math/big/int_test....
src/pkg/math/big/int_test.go:777: {"1", "0", "1", "0"},
On 2014/04/21 22:50:40, adonovan wrote:
> Can you also test 0^0==1?

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b