Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(899)

Issue 90060043: Make control-bucket optional.

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 5 months ago by bac
Modified:
5 years, 5 months ago
Reviewers:
frankban, mp+216634
Visibility:
Public.

Description

Make control-bucket optional. The existing function get_admin_secret is made generic and the name is changed to get_value_from_jenv. It now takes a keyname to be fetched from the generated file. For both ec2 and openstack the control-bucket field has been made optional with respect to the environments.yaml file. QA: 1) Create an ec2 environment with no control-bucket. 2) Bootstrap that environment. Ensure a control-bucket is in the .jenv file. 3) Run quickstart and see that it uses the existing environment and does not raise an error. https://code.launchpad.net/~bac/juju-quickstart/1309678/+merge/216634 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Make control-bucket optional. #

Patch Set 3 : Make control-bucket optional. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -30 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M quickstart/app.py View 1 chunk +10 lines, -8 lines 0 comments Download
M quickstart/manage.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
M quickstart/models/envs.py View 2 chunks +2 lines, -2 lines 0 comments Download
M quickstart/tests/models/test_envs.py View 2 chunks +2 lines, -3 lines 0 comments Download
M quickstart/tests/test_app.py View 1 chunk +8 lines, -6 lines 0 comments Download
M quickstart/tests/test_manage.py View 1 3 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 5
bac
Please take a look.
5 years, 5 months ago (2014-04-21 21:14:45 UTC) #1
frankban
Hi Brad, this branch looks nice. As you mentioned, I am not sure why we ...
5 years, 5 months ago (2014-04-22 09:01:40 UTC) #2
bac
Please take a look.
5 years, 5 months ago (2014-04-22 12:35:20 UTC) #3
frankban
LGTM QA ok.
5 years, 5 months ago (2014-04-22 12:52:04 UTC) #4
bac
5 years, 5 months ago (2014-04-22 13:17:14 UTC) #5
*** Submitted:

Make control-bucket optional.

The existing function get_admin_secret is made generic and the name is changed
to get_value_from_jenv.  It now takes a keyname to be fetched from the
generated file.

For both ec2 and openstack the control-bucket field has been made optional
with respect to the environments.yaml file.

QA:

1) Create an ec2 environment with no control-bucket.
2) Bootstrap that environment.  Ensure a control-bucket is in the .jenv file.
3) Run quickstart and see that it uses the existing environment and does not
raise an error.

R=frankban
CC=
https://codereview.appspot.com/90060043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b