DescriptionAdds filter controls to the search in the browser
- The branch updates the models/browser.js Filter model that is basically the
search state in the application.
- The subapp keeps an instance of that around and updates it along with the
rest of the subapplication state.
- The subapp passes the raw data down into views that can use it to populate
the search related widgets (search and filters).
- When those widgets are changed they trigger a custom event back up to their
controlling View.
- That View then generates a change event to the subapp directing it to update
it's current _filter (the Filter model) with that change and navigate to the
new url.
- All searches are url-able and thus force a navigate and re-process through
the render chain.
- Because of this, the Views do not need to update their version of the
filters, they'll get new ones from the subapp on the next routing.
Known QA issues:
- There's not a good "no results found" display
- There's not a list of selected filters per UX design when the filter list is
collapsed in sidebar view
- Theme'ing needs to be done on the filter list to remove the leading *, make
things more header-like, add proper arrows vs temp ^/v
- It's felt these are correctable through the week while the functionality is
able to be added before 'feature freeze' on Monday.
https://code.launchpad.net/~rharding/juju-gui/search-filters/+merge/161289
(do not edit description out of merge proposal)
Patch Set 1 #
Total comments: 20
Patch Set 2 : Adds filter controls to the search in the browser #Patch Set 3 : Adds filter controls to the search in the browser #Patch Set 4 : Adds filter controls to the search in the browser #Patch Set 5 : Adds filter controls to the search in the browser #Patch Set 6 : Adds filter controls to the search in the browser #Patch Set 7 : Adds filter controls to the search in the browser #Patch Set 8 : Adds filter controls to the search in the browser #
Total comments: 23
Patch Set 9 : Adds filter controls to the search in the browser #Patch Set 10 : Adds filter controls to the search in the browser #Patch Set 11 : Adds filter controls to the search in the browser #Patch Set 12 : Adds filter controls to the search in the browser #Patch Set 13 : Adds filter controls to the search in the browser #
MessagesTotal messages: 18
|