Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(390)

Issue 8984043: gc/ld/runtime: nil pointer checks using only hardware

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 6 months ago by khr
Modified:
13 years, 6 months ago
Reviewers:
Visibility:
Public.

Description

compiler/linker: Fix for nil pointer checks for large objects. Crazy idea of computing the maximum object size, then using that number to offset the virtual address start of the executable so that a reference to anywhere in a big but nil object will fault. Still need to handle other OSes besides linux and osx. Behavior changes for test p9, &p.i used to fault and it won't any more.

Patch Set 1 #

Patch Set 2 : diff -r ad7749774783 https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 3 : diff -r ad7749774783 https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 4 : diff -r 5e23075b0970 https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 5 : diff -r 5e23075b0970 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -149 lines) Patch
M src/cmd/5g/cgen.c View 1 2 3 5 chunks +1 line, -54 lines 0 comments Download
M src/cmd/5l/obj.c View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/6g/cgen.c View 1 2 3 4 chunks +1 line, -44 lines 0 comments Download
M src/cmd/6l/obj.c View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/8g/cgen.c View 1 2 3 5 chunks +1 line, -42 lines 0 comments Download
M src/cmd/8l/obj.c View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/ld/go.c View 1 2 chunks +63 lines, -0 lines 0 comments Download
M src/cmd/ld/lib.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/ld/macho.c View 1 1 chunk +3 lines, -1 line 0 comments Download
M src/pkg/runtime/os_darwin.c View 1 2 3 4 2 chunks +4 lines, -2 lines 0 comments Download
M src/pkg/runtime/os_linux.c View 1 4 chunks +23 lines, -2 lines 0 comments Download
M test/nilptr.go View 1 2 3 3 chunks +8 lines, -4 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b