Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(55)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 89810043: code review 89810043: cmd/nm: disable TestNM on darwin, linux and solaris (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by brainman
Modified:
11 years ago
Reviewers:
aram, dave
CC:
golang-codereviews, dave_cheney.net
Visibility:
Public.

Description

cmd/nm: disable TestNM on darwin, linux and solaris Update issue 7829

Patch Set 1 #

Patch Set 2 : diff -r 4bb6d26852d2 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 4bb6d26852d2 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 4bb6d26852d2 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/cmd/nm/nm_test.go View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4
brainman
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
11 years ago (2014-04-21 10:14:10 UTC) #1
dave_cheney.net
LGTM. Given that adg is trying to produce a release tomorrow, I think it is ...
11 years ago (2014-04-21 10:35:08 UTC) #2
brainman
*** Submitted as https://code.google.com/p/go/source/detail?r=c9fb2985f499 *** cmd/nm: disable TestNM on darwin, linux and solaris Update issue ...
11 years ago (2014-04-21 10:36:46 UTC) #3
aram
11 years ago (2014-04-21 11:01:04 UTC) #4
Message was sent while issue was closed. 
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b