Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(922)

Issue 8975043: TRIVIAL: Remove model attrs not required.

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 5 months ago by rharding
Modified:
11 years, 5 months ago
Reviewers:
mp+161107
Visibility:
Public.

Description

TRIVIAL: Remove model attrs not required. Drive by fix to link the "show me my canvas" link on the fullscreen content. https://code.launchpad.net/~rharding/juju-gui/model-cleanup/+merge/161107 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : TRIVIAL: Remove model attrs not required. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M app/models/charm.js View 1 chunk +0 lines, -2 lines 0 comments Download
M app/subapps/browser/templates/editorial.handlebars View 1 chunk +1 line, -1 line 0 comments Download
M test/data/browsercharm.json View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3
rharding
Please take a look.
11 years, 5 months ago (2013-04-26 12:41:46 UTC) #1
rharding
LGTM - self reviewing trivial.
11 years, 5 months ago (2013-04-26 12:42:37 UTC) #2
rharding
11 years, 5 months ago (2013-04-26 12:46:15 UTC) #3
*** Submitted:

TRIVIAL: Remove model attrs not required.

Drive by fix to link the "show me my canvas" link on the fullscreen content.

R=
CC=
https://codereview.appspot.com/8975043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b