Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(636)

Issue 8958043: Revert 1192 - API support for upgrade-charm (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 7 months ago by dimitern
Modified:
8 years, 7 months ago
Reviewers:
mp+160855
Visibility:
Public.

Description

Revert 1192 - API support for upgrade-charm As discussed, this needs to be done differently. https://code.launchpad.net/~dimitern/juju-core/037-revert-1192/+merge/160855 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Revert 1192 - API support for upgrade-charm #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -155 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/juju/upgradecharm.go View 2 chunks +32 lines, -11 lines 0 comments Download
M state/api/apiclient.go View 1 chunk +0 lines, -10 lines 0 comments Download
M state/api/params/params.go View 1 chunk +0 lines, -7 lines 0 comments Download
M state/apiserver/api_test.go View 2 chunks +0 lines, -16 lines 0 comments Download
M state/apiserver/apiserver.go View 1 chunk +0 lines, -5 lines 0 comments Download
D state/statecmd/upgradecharm.go View 1 chunk +0 lines, -50 lines 0 comments Download
D state/statecmd/upgradecharm_test.go View 1 chunk +0 lines, -56 lines 0 comments Download

Messages

Total messages: 3
dimitern
Please take a look.
8 years, 7 months ago (2013-04-25 10:48:53 UTC) #1
fwereade
LGTM trivial
8 years, 7 months ago (2013-04-25 11:01:11 UTC) #2
dimitern
8 years, 7 months ago (2013-04-25 11:07:49 UTC) #3
*** Submitted:

Revert 1192 - API support for upgrade-charm

As discussed, this needs to be done differently.

R=fwereade
CC=
https://codereview.appspot.com/8958043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b