Issue 89390043: code review 89390043: acme: fix Get of dir in nameless window (thanks Colton ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 89390043: code review 89390043: acme: fix Get of dir in nameless window (thanks Colton ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by rsc

Modified:
10 years, 9 months ago

Reviewers:

CC:
r

Visibility:
Public.

Description

acme: fix Get of dir in nameless window (thanks Colton Lewis)

Patch Set 1 #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/cmd/acme/text.c	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello r, I'd like you to review this change to https://code.google.com/p/plan9port

10 years, 9 months ago (2014-04-18 18:03:42 UTC) #1

rsc

*** Submitted as https://code.google.com/p/plan9port/source/detail?r=db0e4f2b8323 *** acme: fix Get of dir in nameless window (thanks Colton ...

10 years, 9 months ago (2014-04-18 18:03:48 UTC) #2

What is the bug this fixes? How can a directory be nameless? The window can, ...

10 years, 9 months ago (2014-04-18 18:17:35 UTC) #3

rsc

10 years, 9 months ago (2014-04-18 18:54:15 UTC) #4

On Fri, Apr 18, 2014 at 2:17 PM, Rob Pike <r@golang.org> wrote:

> What is the bug this fixes? How can a directory be nameless? The
> window can, but that's not what this is checking.
>

exec 'New'
in new window exec 'Get /tmp'

Also for consistency there shouldn't be spaces around the > but that's
> not important.
>

i put them there there were spaces around the != on the same line.

Expand All Messages | Collapse All Messages