Issue 8935043: Allow multi-line entry on service settings page.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8935043: Allow multi-line entry on service settings page.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by bac

Modified:
11 years ago

Reviewers:
bcsaller, jeff.pihach, mp+160648

Visibility:
Public.

Description

Allow multi-line entry on service settings page. https://code.launchpad.net/~bac/juju-gui/service-settings-multiline/+merge/160648 (do not edit description out of merge proposal)

Patch Set 2 : Allow multi-line entry on service settings page. #

Total comments: 2

Patch Set 3 : Allow multi-line entry on service settings page. #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+127 lines, -41 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/views/service.js	View	1 2	1 chunk	+1 line, -24 lines	0 comments	Download
M	app/views/utils.js	View	1	4 chunks	+27 lines, -8 lines	0 comments	Download
M	test/test_service_view.js	View	1 2	2 chunks	+49 lines, -1 line	0 comments	Download
M	test/test_utils.js	View	1 2	8 chunks	+48 lines, -8 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

jeff.pihach

LGTM thanks! with trivial doc comments https://codereview.appspot.com/8935043/diff/1/app/views/utils.js File app/views/utils.js (right): https://codereview.appspot.com/8935043/diff/1/app/views/utils.js#newcode602 app/views/utils.js:602: @param {Dict} config ...

11 years ago (2013-04-24 14:20:39 UTC) #2

bcsaller

LGTM Thanks. https://codereview.appspot.com/8935043/diff/5001/test/test_service_view.js File test/test_service_view.js (right): https://codereview.appspot.com/8935043/diff/5001/test/test_service_view.js#newcode779 test/test_service_view.js:779: a_bool: {name: 'bob', type: 'boolean', 'default': 'on'}, ...

11 years ago (2013-04-24 17:08:43 UTC) #4

bac

11 years ago (2013-04-24 18:59:03 UTC) #5

*** Submitted:

Allow multi-line entry on service settings page.

R=jeff.pihach, bcsaller
CC=
https://codereview.appspot.com/8935043

https://codereview.appspot.com/8935043/diff/5001/test/test_service_view.js
File test/test_service_view.js (right):

https://codereview.appspot.com/8935043/diff/5001/test/test_service_view.js#ne...
test/test_service_view.js:779: a_bool: {name: 'bob', type: 'boolean', 'default':
'on'},
The values should be True or False but in reality in the YAML any truthy value
works.  I'll change it to not be confusing.

The output value is 'checked' or ''.

Expand All Messages | Collapse All Messages