Issue 89330043: code review 89330043: lib9: restore argv0 initialization code.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 89330043: code review 89330043: lib9: restore argv0 initialization code. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by minux1

Modified:
11 years ago

Reviewers:
r

CC:
golang-codereviews, r

Visibility:
Public.

Description

lib9: restore argv0 initialization code. `GOARCH=arm go tool 6c` used to give "<prog>: cannot use 6c with GOARCH=arm"

Patch Set 1 #

Patch Set 2 : diff -r 510063e3f0b7 https://code.google.com/p/go #

Patch Set 3 : diff -r 510063e3f0b7 https://code.google.com/p/go #

Patch Set 4 : diff -r 8279f39bcaf0 https://code.google.com/p/go #

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/lib9/main.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

minux1

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

11 years ago (2014-04-18 15:08:21 UTC) #1

minux1

11 years ago (2014-04-21 04:08:42 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=98c61cf83997 ***

lib9: restore argv0 initialization code.
`GOARCH=arm go tool 6c` used to give "<prog>: cannot use 6c with GOARCH=arm"

LGTM=r
R=golang-codereviews, r
CC=golang-codereviews
https://codereview.appspot.com/89330043

Expand All Messages | Collapse All Messages