code review 89290043: cmd/gc: call fmtinstallgo() sooner

cmd/gc: avoid %L in error message

Fixes issue 7783

[atom, 2014-04-18 12:03:03]

Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[minux1, 2014-04-18 14:51:58]

lex.c changes look good.

https://codereview.appspot.com/89290043/diff/40001/src/liblink/obj.c
File src/liblink/obj.c (right):

https://codereview.appspot.com/89290043/diff/40001/src/liblink/obj.c#newcode33
src/liblink/obj.c:33: for(h=(ctxt ? ctxt->hist : nil); h!=nil; h=h->link) {
why change this?

and, btw, we don't use tenary operator in C code.

[atom, 2014-04-18 15:01:52]

https://codereview.appspot.com/89290043/diff/40001/src/liblink/obj.c
File src/liblink/obj.c (right):

https://codereview.appspot.com/89290043/diff/40001/src/liblink/obj.c#newcode33
src/liblink/obj.c:33: for(h=(ctxt ? ctxt->hist : nil); h!=nil; h=h->link) {
On 2014/04/18 14:51:59, minux wrote:
> why change this?

The function may get called before the origin of ctxt is initialized.
 
> and, btw, we don't use tenary operator in C code.

Done.

[minux1, 2014-04-18 15:11:14]

On Apr 18, 2014 11:01 AM, <0xE2.0x9A.0x9B@gmail.com> wrote:
>
https://codereview.appspot.com/89290043/diff/40001/src/liblink/obj.c#newcode33
> src/liblink/obj.c:33: for(h=(ctxt ? ctxt->hist : nil); h!=nil;
> h=h->link) {
> On 2014/04/18 14:51:59, minux wrote:
>>
>> why change this?
>
> The function may get called before the origin of ctxt is initialized.
i see. then i suggest we change the offending fatal call to sysfatal as
there is no reason to add %L for that message.

[atom, 2014-04-18 15:20:39]

On 2014/04/18 15:11:14, minux wrote:
> i see. then i suggest we change the offending fatal call to sysfatal as
> there is no reason to add %L for that message.

Done.

[minux1, 2014-04-18 15:28:12]

LGTM if you made two changes.

basically, i think just s/fatal/sysfatal/ is sufficient for this CL.

https://codereview.appspot.com/89290043/diff/80001/src/cmd/gc/lex.c
File src/cmd/gc/lex.c (right):

https://codereview.appspot.com/89290043/diff/80001/src/cmd/gc/lex.c#newcode218
src/cmd/gc/lex.c:218: sysfatal("internal compiler error: cannot use %cg with
GOARCH=%s", thechar, p);
i've sent a separate CL for the argv0 bug.
let's use the original message for consistency with other programs (6c).

[atom, 2014-04-18 15:40:45]

On 2014/04/18 15:28:12, minux wrote:
> LGTM if you made two changes.
> 
> basically, i think just s/fatal/sysfatal/ is sufficient for this CL.
> 
> https://codereview.appspot.com/89290043/diff/80001/src/cmd/gc/lex.c
> File src/cmd/gc/lex.c (right):
> 
> https://codereview.appspot.com/89290043/diff/80001/src/cmd/gc/lex.c#newcode218
> src/cmd/gc/lex.c:218: sysfatal("internal compiler error: cannot use %cg with
> GOARCH=%s", thechar, p);
> i've sent a separate CL for the argv0 bug.
> let's use the original message for consistency with other programs (6c).

I reduced this CL to s/fatal/sysfatal/ and reverted to the original message.

[minux1, 2014-04-18 15:57:02]

LGTM.

[atom, 2014-04-20 09:02:05]

*** Submitted as https://code.google.com/p/go/source/detail?r=7da10a02f6dd ***

cmd/gc: avoid %L in error message

Fixes issue 7783

LGTM=minux.ma
R=rsc, minux.ma
CC=golang-codereviews
https://codereview.appspot.com/89290043