Issue 8925043: code review 8925043: cmd/5g, cmd/6g, cmd/8g: more nil ptr to large struct checks

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8925043: code review 8925043: cmd/5g, cmd/6g, cmd/8g: more nil ptr to large struct checks (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by iant

Modified:
11 years, 11 months ago

Reviewers:

CC:
r, ken2, khr, DMorsing, dsymonds, golang-dev, Ricky Zhou

Visibility:
Public.

Description

cmd/5g, cmd/6g, cmd/8g: more nil ptr to large struct checks

Patch Set 2 : diff -r dc922c5176b5 https://code.google.com/p/go #

Patch Set 3 : diff -r e920ea81e2fa https://code.google.com/p/go #

Patch Set 4 : diff -r e920ea81e2fa https://code.google.com/p/go #

Total comments: 2

Patch Set 5 : diff -r e729bb70416a https://code.google.com/p/go #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+120 lines, -69 lines)			Patch
M	src/cmd/5g/cgen.c	View	1 2	3 chunks	+38 lines, -27 lines	0 comments	Download
M	src/cmd/6g/cgen.c	View	1 2	2 chunks	+30 lines, -21 lines	0 comments	Download
M	src/cmd/8g/cgen.c	View	1 2	3 chunks	+30 lines, -21 lines	0 comments	Download
M	test/nilptr.go	View	1 2	2 chunks	+22 lines, -0 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

iant

Hello r@golang.org, ken@golang.org, khr@golang.org (cc: dsymonds@golang.org, golang-dev@googlegroups.com, rickyz@google.com), I'd like you to review this change ...

11 years, 11 months ago (2013-04-24 13:22:53 UTC) #2

DMorsing

LGTM https://codereview.appspot.com/8925043/diff/8001/src/cmd/6g/cgen.c File src/cmd/6g/cgen.c (right): https://codereview.appspot.com/8925043/diff/8001/src/cmd/6g/cgen.c#newcode895 src/cmd/6g/cgen.c:895: } I don't believe this is neccesary. I ...

11 years, 11 months ago (2013-04-24 14:27:38 UTC) #3

iant

https://codereview.appspot.com/8925043/diff/8001/src/cmd/6g/cgen.c File src/cmd/6g/cgen.c (right): https://codereview.appspot.com/8925043/diff/8001/src/cmd/6g/cgen.c#newcode895 src/cmd/6g/cgen.c:895: } On 2013/04/24 14:27:38, DMorsing wrote: > I don't ...

11 years, 11 months ago (2013-04-24 15:11:51 UTC) #6

iant

11 years, 11 months ago (2013-04-24 15:13:07 UTC) #7

*** Submitted as https://code.google.com/p/go/source/detail?r=37bf155bc780 ***

cmd/5g, cmd/6g, cmd/8g: more nil ptr to large struct checks

R=r, ken, khr, daniel.morsing
CC=dsymonds, golang-dev, rickyz
https://codereview.appspot.com/8925043

Expand All Messages | Collapse All Messages