Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4630)

Issue 8923044: Fixes #1171538 and #1171880

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by rharding
Modified:
11 years ago
Reviewers:
mp+160473, jeff.pihach, curtis
Visibility:
Public.

Description

Fixes #1171538 and #1171880 - Dislpay the first 10 charms in each container on fullscreen view - Clicks on charms from fullscreen open the fullscreen charm details - Drive by: remove the link to the test file that no longer exists - Update the svg code to work since the juju-gui svg was trying hard to show up now. - Add tests for the editorial code. Not sure how I didn't have those before. - Remove sidebar-editorial json file no longer needed. Outdated api - Added the interesting.json for the updated api calls for testing https://code.launchpad.net/~rharding/juju-gui/fullscreen-1171538/+merge/160473 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fixes #1171538 and #1171880 #

Total comments: 3

Patch Set 3 : Fixes #1171538 and #1171880 #

Patch Set 4 : Fixes #1171538 and #1171880 #

Patch Set 5 : Fixes #1171538 and #1171880 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4486 lines, -858 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M app/subapps/browser/templates/browser_charm.handlebars View 1 chunk +1 line, -1 line 0 comments Download
M app/subapps/browser/views/editorial.js View 5 chunks +34 lines, -8 lines 0 comments Download
M app/templates/charm-token.handlebars View 1 chunk +1 line, -1 line 0 comments Download
M lib/views/browser/charm-token.less View 1 chunk +7 lines, -0 lines 0 comments Download
A test/data/interesting.json View 1 chunk +4284 lines, -0 lines 0 comments Download
D test/data/sidebar_editorial.json View 1 chunk +0 lines, -843 lines 0 comments Download
M test/index.html View 1 chunk +1 line, -1 line 0 comments Download
M test/test_browser_app.js View 1 2 4 chunks +9 lines, -4 lines 0 comments Download
A test/test_browser_editorial.js View 1 2 1 chunk +147 lines, -0 lines 0 comments Download

Messages

Total messages: 6
rharding
Please take a look.
11 years ago (2013-04-23 19:04:41 UTC) #1
rharding
Please take a look.
11 years ago (2013-04-23 19:07:27 UTC) #2
curtis
Thank you for this fix. The image/svg+xml change is timely. Aaron and I discussed support ...
11 years ago (2013-04-23 19:17:48 UTC) #3
jeff.pihach
LGTM with a few trivial comments https://codereview.appspot.com/8923044/diff/3001/app/subapps/browser/views/editorial.js File app/subapps/browser/views/editorial.js (right): https://codereview.appspot.com/8923044/diff/3001/app/subapps/browser/views/editorial.js#newcode28 app/subapps/browser/views/editorial.js:28: // How many ...
11 years ago (2013-04-23 19:27:33 UTC) #4
rharding
Please take a look.
11 years ago (2013-04-23 19:45:41 UTC) #5
rharding
11 years ago (2013-04-23 19:56:17 UTC) #6
*** Submitted:

Fixes #1171538 and #1171880

- Dislpay the first 10 charms in each container on fullscreen view
- Clicks on charms from fullscreen open the fullscreen charm details
- Drive by: remove the link to the test file that no longer exists
- Update the svg code to work since the juju-gui svg was trying hard to show
up now.
- Add tests for the editorial code. Not sure how I didn't have those before.
- Remove sidebar-editorial json file no longer needed. Outdated api
- Added the interesting.json for the updated api calls for testing

R=curtis, jeff.pihach
CC=
https://codereview.appspot.com/8923044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b