Issue 8913044: Undo change to cloudinit update logic on raring

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8913044: Undo change to cloudinit update logic on raring

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by gz

Modified:
10 years, 12 months ago

Reviewers:
dimitern, mp+160208, TheMue

Visibility:
Public.

Description

Undo change to cloudinit update logic on raring See the merge proposal that added this workaround for more details: <https://codereview.appspot.com/8648047/> In short smoser has doubts about the fix, and it is unlikely to be an issue once raring has been released. There will be no upstart upgrades without first fixing the underlying problem. https://code.launchpad.net/~gz/juju-core/revert_r1188/+merge/160208 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Undo change to cloudinit update logic on raring #

Patch Set 3 : Undo change to cloudinit update logic on raring #

Patch Set 4 : Undo change to cloudinit update logic on raring #

Created: 10 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -12 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/cloudinit/cloudinit.go	View	2 chunks	+1 line, -7 lines	0 comments	Download
M	environs/cloudinit/cloudinit_test.go	View	2 chunks	+1 line, -5 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dimitern

LGTM, trivial. So if smoser says it's better to back it out, let's do that. ...

11 years ago (2013-04-23 11:04:36 UTC) #2

10 years, 12 months ago (2013-05-10 19:19:23 UTC) #5

*** Submitted:

Undo change to cloudinit update logic on raring

See the merge proposal that added this workaround for more details:

<https://codereview.appspot.com/8648047/>

In short smoser has doubts about the fix, and it is unlikely to be an
issue once raring has been released. There will be no upstart upgrades
without first fixing the underlying problem.

R=
CC=
https://codereview.appspot.com/8913044

Expand All Messages | Collapse All Messages