Issue 891047: Misc issues related to UriManagers

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 891047: Misc issues related to UriManagers

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years ago by zhoresh

Modified:
16 years ago

Reviewers:
johnfargo, shindig.remailer

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk

Visibility:
Public.

Description

Three minor changes attached: - Add equal operator for ProxyUri so it can be easy to write tests - Set schema null instead of empty string for IframeUriManager (for empty string you get url '://') - Change warning to info for Oath bad request

Patch Set 1 #

Created: 16 years ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+70 lines, -21 lines)			Patch
java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthRequest.java	View	3 chunks	+12 lines, -12 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/ConcatUriManager.java	View	2 chunks	+15 lines, -2 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java	View	3 chunks	+6 lines, -6 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/ProxyUriBase.java	View	3 chunks	+20 lines, -1 line	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/ProxyUriManager.java	View	2 chunks	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages