Issue 89090043: code review 89090043: go.net/publicsuffix: when generating table.go, track ho...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 89090043: code review 89090043: go.net/publicsuffix: when generating table.go, track ho... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 11 months ago by nigeltao

Modified:
10 years, 11 months ago

Reviewers:
volker.dobler

CC:
volker.dobler, golang-codereviews

Visibility:
Public.

Description

go.net/publicsuffix: when generating table.go, track how much slack we have in the bit-packing. This was previously printed to stderr by gen.go, but is now written to the generated table.go, so that we have better records of how it changes over time.

Patch Set 1 #

Patch Set 2 : diff -r 7983f46995b7 https://code.google.com/p/go.net #

Patch Set 3 : diff -r 7983f46995b7 https://code.google.com/p/go.net #

Patch Set 4 : diff -r 7983f46995b7 https://code.google.com/p/go.net #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -9 lines)			Patch
	M	publicsuffix/gen.go	View	1	2 chunks	+6 lines, -9 lines	0 comments	Download
	M	publicsuffix/table.go	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

nigeltao

Hello dr.volker.dobler@gmail.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.net

10 years, 11 months ago (2014-04-17 22:10:53 UTC) #1

volker.dobler

LGTM The CL description is a bit misleading: The new stuff is that the usage ...

10 years, 11 months ago (2014-04-17 23:30:33 UTC) #2

nigeltao

10 years, 11 months ago (2014-04-18 02:28:18 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=cdbc77c5e006&repo=net ***

go.net/publicsuffix: when generating table.go, track how much slack we
have in the bit-packing.

This was previously printed to stderr by gen.go, but is now written to
the generated table.go, so that we have better records of how it
changes over time.

LGTM=dr.volker.dobler
R=dr.volker.dobler
CC=golang-codereviews
https://codereview.appspot.com/89090043

Expand All Messages | Collapse All Messages