Issue 89080043: code review 89080043: go.net/publicsuffix: update table to latest list from p...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 89080043: code review 89080043: go.net/publicsuffix: update table to latest list from p... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 11 months ago by nigeltao

Modified:
10 years, 11 months ago

Reviewers:

CC:
golang-codereviews, volker.dobler

Visibility:
Public.

Description

go.net/publicsuffix: update table to latest list from publicsuffix.org.

Patch Set 1 #

Patch Set 2 : diff -r c17ad62118ea https://code.google.com/p/go.net #

Patch Set 3 : diff -r c17ad62118ea https://code.google.com/p/go.net #

Patch Set 4 : diff -r c17ad62118ea https://code.google.com/p/go.net #

Created: 10 years, 11 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7890 lines, -7332 lines)			Patch
	M	publicsuffix/table.go	View	1 2 3	4 chunks	+7312 lines, -7117 lines	0 comments	Download
	M	publicsuffix/table_test.go	View	1 2 3	69 chunks	+578 lines, -215 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

nigeltao

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.net

10 years, 11 months ago (2014-04-17 21:44:03 UTC) #1

nigeltao

10 years, 11 months ago (2014-04-17 21:45:07 UTC) #2

*** Submitted as
https://code.google.com/p/go/source/detail?r=7983f46995b7&repo=net ***

go.net/publicsuffix: update table to latest list from publicsuffix.org.

TBR=volker.dobler
R=golang-codereviews
CC=golang-codereviews
https://codereview.appspot.com/89080043

Expand All Messages | Collapse All Messages