Issue 89040043: code review 89040043: cmd/pack: avoid ./ import in test (fix Windows build)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 89040043: code review 89040043: cmd/pack: avoid ./ import in test (fix Windows build) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by rsc

Modified:
11 years, 1 month ago

Reviewers:
iant

CC:
iant, golang-codereviews

Visibility:
Public.

Description

cmd/pack: avoid ./ import in test (fix Windows build) It is possible to use ./ imports on Windows but it requires some extra command-line work ('go build' does this automatically, but we can't use 'go build' here). Instead, use an ordinary import and -I/-L, which are easier to use.

Patch Set 1 #

Patch Set 2 : diff -r e00d4dccf31f https://code.google.com/p/go/ #

Patch Set 3 : diff -r e00d4dccf31f https://code.google.com/p/go/ #

Patch Set 4 : diff -r e00d4dccf31f https://code.google.com/p/go/ #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	src/cmd/pack/pack_test.go	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello iant (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

11 years, 1 month ago (2014-04-17 20:24:30 UTC) #1

rsc

11 years, 1 month ago (2014-04-17 20:25:42 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=31d9280833b4 ***

cmd/pack: avoid ./ import in test (fix Windows build)

It is possible to use ./ imports on Windows but it
requires some extra command-line work
('go build' does this automatically, but we can't use 'go build' here).

Instead, use an ordinary import and -I/-L, which are easier to use.

LGTM=iant
R=iant
CC=golang-codereviews
https://codereview.appspot.com/89040043

Expand All Messages | Collapse All Messages