Use Twisted which function instead of relying on OS in test runner. Fixes #62.

Use Twisted which function instead of relying on OS in test runner. Fixes #62.

[fredsa.google, 2013-04-26 22:16:36]

LGTM

https://codereview.appspot.com/8893044/diff/1/endpoints_proto_datastore/endpo...
File endpoints_proto_datastore/endpoints_proto_datastore_test_runner.py (right):

https://codereview.appspot.com/8893044/diff/1/endpoints_proto_datastore/endpo...
endpoints_proto_datastore/endpoints_proto_datastore_test_runner.py:39: #
TODO(dhermes): Support finding the correct location on Windows too.
get rid of TODO?

https://codereview.appspot.com/8893044/diff/1/endpoints_proto_datastore/test_...
File endpoints_proto_datastore/test_utils.py (right):

https://codereview.appspot.com/8893044/diff/1/endpoints_proto_datastore/test_...
endpoints_proto_datastore/test_utils.py:22: 'twisted/python/procutils.py')
You probably should mention the inclusion of this 3rd party code (incl. the fact
that the LICENSE differes) in a top level README.txt or similar.

https://codereview.appspot.com/8893044/diff/1/endpoints_proto_datastore/test_...
endpoints_proto_datastore/test_utils.py:22: 'twisted/python/procutils.py')
Maybe move this note to a top level module comment

[dhermes, 2013-04-26 22:20:55]

https://codereview.appspot.com/8893044/diff/1/endpoints_proto_datastore/endpo...
File endpoints_proto_datastore/endpoints_proto_datastore_test_runner.py (right):

https://codereview.appspot.com/8893044/diff/1/endpoints_proto_datastore/endpo...
endpoints_proto_datastore/endpoints_proto_datastore_test_runner.py:39: #
TODO(dhermes): Support finding the correct location on Windows too.
On 2013/04/26 22:16:36, fredsa.google wrote:
> get rid of TODO?

Done.

https://codereview.appspot.com/8893044/diff/1/endpoints_proto_datastore/test_...
File endpoints_proto_datastore/test_utils.py (right):

https://codereview.appspot.com/8893044/diff/1/endpoints_proto_datastore/test_...
endpoints_proto_datastore/test_utils.py:22: 'twisted/python/procutils.py')
On 2013/04/26 22:16:36, fredsa.google wrote:
> You probably should mention the inclusion of this 3rd party code (incl. the
fact
> that the LICENSE differes) in a top level README.txt or similar.

Updating the README. As for top-level module comment, this is "test_utils" and I
expect to have other code written directly by me.

[dhermes, 2013-04-26 22:35:09]

Addressing review comments.

[fredsa.google, 2013-04-26 22:37:15]

https://codereview.appspot.com/8893044/diff/7001/endpoints_proto_datastore/en...
File endpoints_proto_datastore/endpoints_proto_datastore_test_runner.py (right):

https://codereview.appspot.com/8893044/diff/7001/endpoints_proto_datastore/en...
endpoints_proto_datastore/endpoints_proto_datastore_test_runner.py:40: # is not
on the path, then 'which' will exit with status code 1 and
THe new which() is documented as returning None rather than status code 1

[fredsa.google, 2013-04-26 22:37:49]

https://codereview.appspot.com/8893044/diff/7001/endpoints_proto_datastore/te...
File endpoints_proto_datastore/test_utils.py (right):

https://codereview.appspot.com/8893044/diff/7001/endpoints_proto_datastore/te...
endpoints_proto_datastore/test_utils.py:6: LICENSE. See the README for this
project for more details.
README.md

[dhermes, 2013-04-26 22:39:01]

Making comments/docstrings more clear.

[dhermes, 2013-04-26 22:39:16]

Added in
https://github.com/GoogleCloudPlatform/endpoints-proto-datastore/commit/0b0d5...