Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1124)

Issue 8883043: Bug fix: routes being dispatched multiple times

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by jeff.pihach
Modified:
9 years, 7 months ago
Reviewers:
bcsaller, gary.poster, mp+159916
Visibility:
Public.

Description

Bug fix: routes being dispatched multiple times Ever since we added namespace aware routing we have had an issue which caused routes to be dispatched multiple times. This stops that from happening while maintaining the proper browser history entries allowing back/forward functionality. https://code.launchpad.net/~hatch/juju-gui/multi-dispatch/+merge/159916 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 5

Patch Set 2 : Bug fix: routes being dispatched multiple times #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -17 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M app/assets/javascripts/ns-routing-app-extension.js View 1 1 chunk +1 line, -16 lines 0 comments Download
M app/views/topology/service.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
jeff.pihach
Please take a look.
9 years, 7 months ago (2013-04-20 03:46:15 UTC) #1
gary.poster
LGTM, with possible addition in navigate per my comment, at your discretion. For my "I'm ...
9 years, 7 months ago (2013-04-22 12:46:00 UTC) #2
jeff.pihach
Thanks for the review! https://codereview.appspot.com/8883043/diff/1/app/assets/javascripts/ns-routing-app-extension.js File app/assets/javascripts/ns-routing-app-extension.js (right): https://codereview.appspot.com/8883043/diff/1/app/assets/javascripts/ns-routing-app-extension.js#newcode272 app/assets/javascripts/ns-routing-app-extension.js:272: navigate: function(url, options) { It ...
9 years, 7 months ago (2013-04-22 14:42:39 UTC) #3
bcsaller
LGTM Did basic QA and it seems to work fine, thanks for tracking this down. ...
9 years, 7 months ago (2013-04-22 15:52:44 UTC) #4
jeff.pihach
9 years, 7 months ago (2013-04-22 16:41:19 UTC) #5
*** Submitted:

Bug fix: routes being dispatched multiple times

Ever since we added namespace aware routing we have had
an issue which caused routes to be dispatched multiple
times. This stops that from happening while maintaining
the proper browser history entries allowing back/forward
functionality.

R=gary.poster, bcsaller
CC=
https://codereview.appspot.com/8883043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b