Issue 88820043: code review 88820043: cmd/nm: print symbol sizes for windows pe executables

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 88820043: code review 88820043: cmd/nm: print symbol sizes for windows pe executables (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 11 months ago by brainman

Modified:
10 years, 11 months ago

Reviewers:
r

CC:
golang-codereviews, r

Visibility:
Public.

Description

cmd/nm: print symbol sizes for windows pe executables Fixes issue 6973

Patch Set 1 #

Patch Set 2 : diff -r 878980a46a58 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 878980a46a58 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r eef7ccb39676 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r eef7ccb39676 https://go.googlecode.com/hg/ #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -5 lines)			Patch
M	src/cmd/nm/pe.go	View	1	3 chunks	+14 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/arch_amd64.h	View	1 2 3	1 chunk	+5 lines, -1 line	0 comments	Download
M	src/pkg/runtime/runtime_test.go	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

brainman

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

10 years, 11 months ago (2014-04-17 04:58:16 UTC) #1

brainman

On 2014/04/18 21:01:15, r wrote: > LGTM It appears my change is broken on windows/amd64 ...

10 years, 11 months ago (2014-04-19 02:09:14 UTC) #3

brainman

Hello golang-codereviews@googlegroups.com, r@golang.org (cc: golang-codereviews@googlegroups.com), Please take another look.

10 years, 11 months ago (2014-04-19 02:09:33 UTC) #4

brainman

10 years, 11 months ago (2014-04-19 04:47:29 UTC) #6

*** Submitted as https://code.google.com/p/go/source/detail?r=2114e9e65d6c ***

cmd/nm: print symbol sizes for windows pe executables

Fixes issue 6973

LGTM=r
R=golang-codereviews, r
CC=golang-codereviews
https://codereview.appspot.com/88820043

Expand All Messages | Collapse All Messages