CPP: Make libphonenumber depend on its own base/ when it's used in Chromium.

CPP: Make libphonenumber depend on its own base/ when it's used in Chromium.

This is done by adding a USE_BOOST compile time flag that is enabled by default
when the library is compiled with CMake (mainly for external users).

In Chromium, the library will be built without the USE_BOOST compile time flag.
Instead the NO_THREAD_SAFETY flag will have to be provided so that the minimal
non-thread-safe subset of base will be used.
This is possible since libphonenumber is only used from the UI thread in
Chromium.

BUG=http://crbug.com/236272
R=jia.shao.peng@gmail.com

Committed: https://code.google.com/p/libphonenumber/source/detail?r=568

[Shaopeng, 2013-04-29 16:32:19]

LGTM.

Could you double check the README is still up-to-date with your changes today?

Thanks,

Shaopeng

[pliard1, 2013-04-29 16:42:41]

On 2013/04/29 16:32:19, Shaopeng wrote:
> LGTM.
> 
> Could you double check the README is still up-to-date with your changes today?
> 
> Thanks,
> 
> Shaopeng

Thanks Shaopeng! I have just updated the README.

[Shaopeng, 2013-04-30 07:52:46]

Thanks Philippe! Still LGTM.

On 2013/04/29 16:42:41, pliard1 wrote:
> On 2013/04/29 16:32:19, Shaopeng wrote:
> > LGTM.
> > 
> > Could you double check the README is still up-to-date with your changes
today?
> > 
> > Thanks,
> > 
> > Shaopeng
> 
> Thanks Shaopeng! I have just updated the README.

[pliard1, 2013-04-30 07:56:33]

On 2013/04/30 07:52:46, Shaopeng wrote:
> Thanks Philippe! Still LGTM.
> 
> On 2013/04/29 16:42:41, pliard1 wrote:
> > On 2013/04/29 16:32:19, Shaopeng wrote:
> > > LGTM.
> > > 
> > > Could you double check the README is still up-to-date with your changes
> today?
> > > 
> > > Thanks,
> > > 
> > > Shaopeng
> > 
> > Thanks Shaopeng! I have just updated the README.

Thanks Shaopeng! I will wait a bit before I submit this. They actually appear to
be using libphonenumber from multiple threads in Chromium. I'm not sure what
they mean by libphonenumber. It is safe to pass some Protobuf messages (e.g.
PhoneNumber) from one thread to another one but
PhoneNumberUtil/PhoneNumberMatcher should be used from a single thread (in
Chromium only) with this patch. I will request more information from them.

[pliard1, 2013-04-30 11:44:14]

On 2013/04/30 07:56:33, pliard1 wrote:
> On 2013/04/30 07:52:46, Shaopeng wrote:
> > Thanks Philippe! Still LGTM.
> > 
> > On 2013/04/29 16:42:41, pliard1 wrote:
> > > On 2013/04/29 16:32:19, Shaopeng wrote:
> > > > LGTM.
> > > > 
> > > > Could you double check the README is still up-to-date with your changes
> > today?
> > > > 
> > > > Thanks,
> > > > 
> > > > Shaopeng
> > > 
> > > Thanks Shaopeng! I have just updated the README.
> 
> Thanks Shaopeng! I will wait a bit before I submit this. They actually appear
to
> be using libphonenumber from multiple threads in Chromium. I'm not sure what
> they mean by libphonenumber. It is safe to pass some Protobuf messages (e.g.
> PhoneNumber) from one thread to another one but
> PhoneNumberUtil/PhoneNumberMatcher should be used from a single thread (in
> Chromium only) with this patch. I will request more information from them.

I'm submitting now. Ilya confirmed that the library is now only used from the UI
thread. I will send a follow up CL to add some DCHECKs to make sure the library
is not used from multiple threads.

[pliard1, 2013-04-30 12:08:13]

Committed patchset #2 manually as r568 (presubmit successful).

[tfarina1, 2013-04-30 16:40:55]

Thanks for doing this Philipe!

https://codereview.appspot.com/8859052/diff/2003/cpp/src/phonenumbers/base/ba...
File cpp/src/phonenumbers/base/basictypes.h (right):

https://codereview.appspot.com/8859052/diff/2003/cpp/src/phonenumbers/base/ba...
cpp/src/phonenumbers/base/basictypes.h:109: #define
DISALLOW_EVIL_CONSTRUCTORS(TypeName) DISALLOW_COPY_AND_ASSIGN(TypeName)
do you use this macro in libphonenumber? If not, can we remove it?