Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(697)

Issue 8858047: code review 8858047: cmd/ld: emit relocs for DWARF info when doing an extern... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 6 months ago by iant
Modified:
7 years, 6 months ago
Reviewers:
CC:
golang-dev, dfc, DMorsing, rsc
Visibility:
Public.

Description

cmd/ld: emit relocs for DWARF info when doing an external link I would like opinions on whether this is a good idea for 1.1. On the one hand it's a moderately important issue. On the other hand this introduces at least the possibility of external linker errors due to the additional relocations and it may be better to wait. I'm fairly confident that the behaviour is unchanged when not using an external linker. Update issue 5221 This CL is tested lightly on 386 and amd64 and fixes the cases I tested. I have not tested it on Darwin or Windows.

Patch Set 1 #

Patch Set 2 : diff -r e357a18564cd https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r e72dad7d537b https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+230 lines, -35 lines) Patch
M src/cmd/ld/dwarf.c View 1 22 chunks +196 lines, -31 lines 0 comments Download
M src/cmd/ld/elf.h View 3 chunks +4 lines, -1 line 0 comments Download
M src/cmd/ld/elf.c View 1 chunk +1 line, -3 lines 0 comments Download
M src/cmd/ld/lib.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/cmd/ld/symtab.c View 2 chunks +27 lines, -0 lines 0 comments Download

Messages

Total messages: 8
iant
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
7 years, 6 months ago (2013-04-29 02:56:52 UTC) #1
dfc
Hi Ian, This CL appears to crash reliably on 10.7.5 darwin/amd64: --- FAIL: TestCgoCrashHandler (1.19 ...
7 years, 6 months ago (2013-04-29 08:12:45 UTC) #2
iant
On 2013/04/29 08:12:45, dfc wrote: > > This CL appears to crash reliably on 10.7.5 ...
7 years, 6 months ago (2013-04-29 12:44:19 UTC) #3
dfc
Here you go, I hope this is useful Starting program: /Users/dfc/go/pkg/tool/darwin_amd64/6l -o cgo -L /var/folders/7q/5n_khbqj5z716gk0zvtywgv80000gn/T/go-build731692523 ...
7 years, 6 months ago (2013-04-29 13:03:20 UTC) #4
iant
On 2013/04/29 13:03:20, dfc wrote: > Here you go, I hope this is useful Thanks, ...
7 years, 6 months ago (2013-04-29 16:32:20 UTC) #5
DMorsing
Tried this out with "GNU ld version 2.23.51.0.1-6.fc18". Worked as expected. I am in favor ...
7 years, 6 months ago (2013-04-29 20:37:29 UTC) #6
rsc
LGTM I think this should go into Go 1.1. Having broken debug info is worse ...
7 years, 6 months ago (2013-04-30 18:30:03 UTC) #7
iant
7 years, 6 months ago (2013-04-30 21:01:07 UTC) #8
*** Submitted as https://code.google.com/p/go/source/detail?r=cdedb129e020 ***

cmd/ld: emit relocs for DWARF info when doing an external link

I would like opinions on whether this is a good idea for 1.1.
On the one hand it's a moderately important issue.  On the
other hand this introduces at least the possibility of
external linker errors due to the additional relocations and
it may be better to wait.

I'm fairly confident that the behaviour is unchanged when not
using an external linker.

Update issue 5221

This CL is tested lightly on 386 and amd64 and fixes the cases
I tested.  I have not tested it on Darwin or Windows.

R=golang-dev, dave, daniel.morsing, rsc
CC=golang-dev
https://codereview.appspot.com/8858047
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b