Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(948)

Issue 8855: Support Tru64 in protobuf (with the Symbian solution for the const T& and const T* problem)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 5 months ago by choiniere.vincent
Modified:
14 years, 9 months ago
Reviewers:
kenton
Base URL:
http://protobuf.googlecode.com/svn/trunk/
Visibility:
Public.

Description

This is the patch of the 7041 apply of the r59: But instead of removing the FormatForFailureMessage which cause some problem with HP C++ on Tru64, we use the solution of the Symbian compiler. Because, it seem that the HP C++ work in the same way of Symbian....

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -56 lines) Patch
README.txt View 2 chunks +9 lines, -1 line 0 comments Download
src/google/protobuf/compiler/cpp/cpp_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
src/google/protobuf/descriptor.cc View 2 chunks +14 lines, -4 lines 0 comments Download
src/google/protobuf/descriptor_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
src/google/protobuf/io/zero_copy_stream_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download
src/google/protobuf/message.h View 1 chunk +7 lines, -0 lines 0 comments Download
src/google/protobuf/repeated_field.h View 3 chunks +26 lines, -3 lines 0 comments Download
src/google/protobuf/repeated_field.cc View 2 chunks +8 lines, -1 line 0 comments Download
src/google/protobuf/stubs/common.h View 1 chunk +5 lines, -1 line 0 comments Download
src/google/protobuf/stubs/strutil.h View 1 chunk +4 lines, -0 lines 0 comments Download
src/google/protobuf/stubs/strutil.cc View 1 chunk +7 lines, -2 lines 0 comments Download
src/google/protobuf/text_format_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
src/gtest/gtest.cc View 4 chunks +18 lines, -25 lines 0 comments Download
src/gtest/internal/gtest-internal.h View 2 chunks +6 lines, -6 lines 2 comments Download
src/gtest/internal/gtest-port.h View 2 chunks +8 lines, -7 lines 1 comment Download

Messages

Total messages: 2
choiniere.vincent
15 years, 5 months ago (2008-11-14 15:13:57 UTC) #1
choiniere.vincent
15 years, 5 months ago (2008-11-14 15:25:13 UTC) #2
This patch should be okai now.

http://codereview.appspot.com/8855/diff/1/15
File src/gtest/internal/gtest-internal.h (right):

http://codereview.appspot.com/8855/diff/1/15#newcode220
Line 220: 

I check for __DECCXX and __osf__ because perhaps this problem does'nt occur with
the HP C++ on linux plateform.

http://codereview.appspot.com/8855/diff/1/15#newcode246
Line 246: }
This part is still there : so the warning problem should not occur.

http://codereview.appspot.com/8855/diff/1/16
File src/gtest/internal/gtest-port.h (right):

http://codereview.appspot.com/8855/diff/1/16#newcode447
Line 447: 
This is the modification for using the Symbian solution.

I check for __DECCXX and __osf__ because perhaps this problem does'nt occur with
the HP C++ on linux plateform.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b