Fix ghost service removal

Fix ghost service removal

Fix for bug 1170309: no way to remove a ghost 
service after searching for a charm.

This branch takes care of removing pending services when:
- another ghost is going to be created;
- the service configuration panel is replaced by another
  panel (e.g. charm results after a search).

Also re-organized ghost service tests.

https://code.launchpad.net/~frankban/juju-gui/bug-1170309-ghost/+merge/159675

(do not edit description out of merge proposal)

[frankban, 2013-04-18 16:42:33]

Please take a look.

[bac, 2013-04-18 17:56:37]

LGTM with the addition of some comments and test clean-up.  Thanks!

https://codereview.appspot.com/8843045/diff/1/test/test_charm_panel.js
File test/test_charm_panel.js (right):

https://codereview.appspot.com/8843045/diff/1/test/test_charm_panel.js#newcod...
test/test_charm_panel.js:186: app = {db: db, views: {environment: {}}, env:
env};
As previous, a comment that you're making a mock app would be nice.

https://codereview.appspot.com/8843045/diff/1/test/test_charm_panel.js#newcod...
test/test_charm_panel.js:246: // A deployed service will be preserved.
These services should be destroyed at the end of the test.

[matthew.scott, 2013-04-18 22:09:19]

LGTM - thanks for the fix.

[frankban, 2013-04-19 08:11:52]

*** Submitted:

Fix ghost service removal

Fix for bug 1170309: no way to remove a ghost 
service after searching for a charm.

This branch takes care of removing pending services when:
- another ghost is going to be created;
- the service configuration panel is replaced by another
  panel (e.g. charm results after a search).

Also re-organized ghost service tests.

R=bac, matthew.scott
CC=
https://codereview.appspot.com/8843045

https://codereview.appspot.com/8843045/diff/1/test/test_charm_panel.js
File test/test_charm_panel.js (right):

https://codereview.appspot.com/8843045/diff/1/test/test_charm_panel.js#newcod...
test/test_charm_panel.js:186: app = {db: db, views: {environment: {}}, env:
env};
On 2013/04/18 17:56:37, bac wrote:
> As previous, a comment that you're making a mock app would be nice.

Done.

https://codereview.appspot.com/8843045/diff/1/test/test_charm_panel.js#newcod...
test/test_charm_panel.js:246: // A deployed service will be preserved.
On 2013/04/18 17:56:37, bac wrote:
> These services should be destroyed at the end of the test.

I am curious about the reason to remove services here. AFAICT, the db will
eventually go out of scope anyway, and we should not have isolation issues. If I
am missing something, please let me know: other tests in this test case leave
services around. An easy clean up could be a db.reset() in afterEach: I'll do
that in my next branch if you think it's required.

[frankban, 2013-04-19 08:15:55]

Hi Brad and Matthew,
thanks for your reviews!