Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(25)

Issue 8842044: code review 8842044: misc/dashboard/builder: always do a native build (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 5 months ago by dfc
Modified:
9 years, 5 months ago
Reviewers:
CC:
bradfitz, dsymonds, r, adg, golang-dev
Visibility:
Public.

Description

misc/dashboard/builder: always do a native build https://codereview.appspot.com/8134043 disabled cgo when cross compiling, this means builders which compile for both amd64 and 386 will be compiling the latter with cgo disabled. This proposal modifies the builder to mirror the dist tool by always doing a native build. Tested on my darwin/amd64 builder and confirmed the result when building darwin/386 is a native 386 build with cgo enabled.

Patch Set 1 #

Patch Set 2 : diff -r e974430a6f67 https://code.google.com/p/go #

Patch Set 3 : diff -r e974430a6f67 https://code.google.com/p/go #

Total comments: 1

Patch Set 4 : diff -r e974430a6f67 https://code.google.com/p/go #

Patch Set 5 : diff -r e974430a6f67 https://code.google.com/p/go #

Patch Set 6 : diff -r 4543c39256f9 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M misc/dashboard/builder/main.go View 1 2 3 3 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 9
bradfitz
https://codereview.appspot.com/8842044/diff/5001/misc/dashboard/builder/main.go File misc/dashboard/builder/main.go (right): https://codereview.appspot.com/8842044/diff/5001/misc/dashboard/builder/main.go#newcode417 misc/dashboard/builder/main.go:417: // do nothing say why?
9 years, 5 months ago (2013-04-18 02:21:15 UTC) #1
dfc
Please take another look, changed the approach to match what the dist tool does, which ...
9 years, 5 months ago (2013-04-18 04:49:42 UTC) #2
dfc
Hello bradfitz@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
9 years, 5 months ago (2013-04-18 04:50:08 UTC) #3
bradfitz
LGTM if that does it. Seems plausible.
9 years, 5 months ago (2013-04-18 06:02:40 UTC) #4
dfc
dsymonds -- do you want to take a look at this for the linux/386 builder ...
9 years, 5 months ago (2013-04-18 06:06:15 UTC) #5
dsymonds
LGTM Let's give it a go.
9 years, 5 months ago (2013-04-18 06:20:59 UTC) #6
dfc
I have applied this CL to the darwin-386-cheney builder and it has passed the crypto ...
9 years, 5 months ago (2013-04-18 06:36:36 UTC) #7
bradfitz
This doesn't fall under go1.1 strictness. Submit away. On Apr 17, 2013 11:36 PM, <dave@cheney.net> ...
9 years, 5 months ago (2013-04-18 06:37:47 UTC) #8
dfc
9 years, 5 months ago (2013-04-18 06:43:09 UTC) #9
*** Submitted as https://code.google.com/p/go/source/detail?r=654eb0e0adf4 ***

misc/dashboard/builder: always do a native build

https://codereview.appspot.com/8134043 disabled cgo when cross compiling, this
means builders which compile for both amd64 and 386 will be compiling the latter
with cgo disabled.

This proposal modifies the builder to mirror the dist tool by always doing a
native build.

Tested on my darwin/amd64 builder and confirmed the result when building
darwin/386 is a native 386 build with cgo enabled.

R=bradfitz, dsymonds, r, adg
CC=golang-dev
https://codereview.appspot.com/8842044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b