code review 8842044: misc/dashboard/builder: always do a native build

misc/dashboard/builder: always do a native build

https://codereview.appspot.com/8134043 disabled cgo when cross compiling, this means builders which compile for both amd64 and 386 will be compiling the latter with cgo disabled.

This proposal modifies the builder to mirror the dist tool by always doing a native build.

Tested on my darwin/amd64 builder and confirmed the result when building darwin/386 is a native 386 build with cgo enabled.

[bradfitz, 2013-04-18 02:21:15]

https://codereview.appspot.com/8842044/diff/5001/misc/dashboard/builder/main.go
File misc/dashboard/builder/main.go (right):

https://codereview.appspot.com/8842044/diff/5001/misc/dashboard/builder/main....
misc/dashboard/builder/main.go:417: // do nothing
say why?

[dave_cheney.net, 2013-04-18 04:49:42]

Please take another look, changed the approach to match what the dist tool does,
which I believe is correct.

[dave_cheney.net, 2013-04-18 04:50:08]

Hello bradfitz@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[bradfitz, 2013-04-18 06:02:40]

LGTM if that does it. Seems plausible.

[dave_cheney.net, 2013-04-18 06:06:15]

dsymonds -- do you want to take a look at this for the linux/386 builder ?

[dsymonds, 2013-04-18 06:20:59]

LGTM

Let's give it a go.

[dave_cheney.net, 2013-04-18 06:36:36]

I have applied this CL to the darwin-386-cheney builder and it has passed the
crypto tests for the recently committed 4543c39256f9.

Waiting on r or adg for permission to submit this.

[bradfitz, 2013-04-18 06:37:47]

This doesn't fall under go1.1 strictness.

Submit away.
 On Apr 17, 2013 11:36 PM, <dave@cheney.net> wrote:

> I have applied this CL to the darwin-386-cheney builder and it has
> passed the crypto tests for the recently committed 4543c39256f9.
>
> Waiting on r or adg for permission to submit this.
>
>
https://codereview.appspot.**com/8842044/<https://codereview.appspot.com/8842...
>

[dave_cheney.net, 2013-04-18 06:43:09]

*** Submitted as https://code.google.com/p/go/source/detail?r=654eb0e0adf4 ***

misc/dashboard/builder: always do a native build

https://codereview.appspot.com/8134043 disabled cgo when cross compiling, this
means builders which compile for both amd64 and 386 will be compiling the latter
with cgo disabled.

This proposal modifies the builder to mirror the dist tool by always doing a
native build.

Tested on my darwin/amd64 builder and confirmed the result when building
darwin/386 is a native 386 build with cgo enabled.

R=bradfitz, dsymonds, r, adg
CC=golang-dev
https://codereview.appspot.com/8842044