Issue 8839047: environs: fix WriteCertAndKeyToHome

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8839047: environs: fix WriteCertAndKeyToHome

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by rog

Modified:
11 years ago

Reviewers:
mp+160422, fwereade, TheMue

Visibility:
Public.

Description

environs: fix WriteCertAndKeyToHome It needs to write to JujuHome, not Home. I've changed the name to reflect the change in use. Also fixed a missing mutex lock in config.JujuHome. https://code.launchpad.net/~rogpeppe/juju-core/295-fix-write-cert-and-key/+merge/160422 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs: fix WriteCertAndKeyToHome #

Patch Set 3 : environs: fix WriteCertAndKeyToHome #

Patch Set 4 : environs: fix WriteCertAndKeyToHome #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -17 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/juju/bootstrap.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	environs/cert.go	View	1	1 chunk	+7 lines, -5 lines	0 comments	Download
M	environs/cert_test.go	View		2 chunks	+17 lines, -11 lines	0 comments	Download
M	environs/config/home.go	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rog

11 years ago (2013-04-25 15:08:09 UTC) #5

*** Submitted:

environs: fix WriteCertAndKeyToHome

It needs to write to JujuHome, not Home.
I've changed the name to reflect the change in use.

Also fixed a missing mutex lock in config.JujuHome.

R=TheMue, fwereade
CC=
https://codereview.appspot.com/8839047

Expand All Messages | Collapse All Messages