Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(96)

Issue 8839047: environs: fix WriteCertAndKeyToHome

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by rog
Modified:
9 years, 7 months ago
Reviewers:
mp+160422, fwereade, TheMue
Visibility:
Public.

Description

environs: fix WriteCertAndKeyToHome It needs to write to JujuHome, not Home. I've changed the name to reflect the change in use. Also fixed a missing mutex lock in config.JujuHome. https://code.launchpad.net/~rogpeppe/juju-core/295-fix-write-cert-and-key/+merge/160422 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs: fix WriteCertAndKeyToHome #

Patch Set 3 : environs: fix WriteCertAndKeyToHome #

Patch Set 4 : environs: fix WriteCertAndKeyToHome #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -17 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/juju/bootstrap.go View 1 chunk +1 line, -1 line 0 comments Download
M environs/cert.go View 1 1 chunk +7 lines, -5 lines 0 comments Download
M environs/cert_test.go View 2 chunks +17 lines, -11 lines 0 comments Download
M environs/config/home.go View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5
rog
Please take a look.
9 years, 7 months ago (2013-04-23 16:23:44 UTC) #1
TheMue
LGTM, dunno how I missed that.
9 years, 7 months ago (2013-04-23 17:01:43 UTC) #2
fwereade
LGTM
9 years, 7 months ago (2013-04-24 16:13:23 UTC) #3
rog
Please take a look.
9 years, 7 months ago (2013-04-25 15:05:59 UTC) #4
rog
9 years, 7 months ago (2013-04-25 15:08:09 UTC) #5
*** Submitted:

environs: fix WriteCertAndKeyToHome

It needs to write to JujuHome, not Home.
I've changed the name to reflect the change in use.

Also fixed a missing mutex lock in config.JujuHome.

R=TheMue, fwereade
CC=
https://codereview.appspot.com/8839047
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b