Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2586)

Issue 8830043: Implemented fakebackend remove_relation

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by jeff.pihach
Modified:
9 years, 7 months ago
Reviewers:
bcsaller, mp+159407, gary.poster
Visibility:
Public.

Description

Implemented fakebackend remove_relation Created unit and sandbox integration tests and qa'd to make sure that it worked properly with the GUI. https://code.launchpad.net/~hatch/juju-gui/rem-rel/+merge/159407 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 15

Patch Set 2 : Implemented fakebackend remove_relation #

Total comments: 2

Patch Set 3 : Implemented fakebackend remove_relation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+319 lines, -31 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M app/store/env/fakebackend.js View 1 6 chunks +101 lines, -28 lines 0 comments Download
M app/store/env/sandbox.js View 2 chunks +23 lines, -3 lines 0 comments Download
M test/test_fakebackend.js View 1 1 chunk +106 lines, -0 lines 0 comments Download
M test/test_sandbox.js View 1 2 chunks +87 lines, -0 lines 0 comments Download

Messages

Total messages: 7
jeff.pihach
Please take a look.
9 years, 7 months ago (2013-04-17 14:56:01 UTC) #1
gary.poster
LGTM with reverting config-debug.js, and then merging trunk and getting the tests to pass again. ...
9 years, 7 months ago (2013-04-17 15:22:32 UTC) #2
jeff.pihach
Thanks for the review, changes made and trunk merged! https://codereview.appspot.com/8830043/diff/1/app/config-debug.js File app/config-debug.js (right): https://codereview.appspot.com/8830043/diff/1/app/config-debug.js#newcode27 app/config-debug.js:27: ...
9 years, 7 months ago (2013-04-17 16:09:04 UTC) #3
jeff.pihach
Please take a look.
9 years, 7 months ago (2013-04-17 16:12:41 UTC) #4
bcsaller
LGTM A few trivial comments, I would prefer using the helper. Extracting the relation match ...
9 years, 7 months ago (2013-04-17 17:10:24 UTC) #5
jeff.pihach
Thanks for the reviews! Ben I'm going to make a followup to look into creating ...
9 years, 7 months ago (2013-04-17 21:27:30 UTC) #6
jeff.pihach
9 years, 7 months ago (2013-04-17 21:30:03 UTC) #7
*** Submitted:

Implemented fakebackend remove_relation

Created unit and sandbox integration tests and qa'd
to make sure that it worked properly with the GUI.

R=gary.poster, bcsaller
CC=
https://codereview.appspot.com/8830043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b