Issue 8827045: code review 8827045: cmd/ld: don't show cursym in gcc invocation failure message

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8827045: code review 8827045: cmd/ld: don't show cursym in gcc invocation failure message (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by minux1

Modified:
12 years, 8 months ago

Reviewers:

CC:
golang-dev, iant, r

Visibility:
Public.

Description

cmd/ld: don't show cursym in gcc invocation failure message before: fmt.statictmp_0731:/usr/local/go/pkg/tool/linux_amd64/6l: running gcc failed: unsuccessful exit status 0x100 now: /usr/local/go/pkg/tool/linux_amd64/6l: running gcc failed: unsuccessful exit status 0x100

Patch Set 1 #

Patch Set 2 : diff -r 13e00572ed0b https://code.google.com/p/go #

Patch Set 3 : diff -r 13e00572ed0b https://code.google.com/p/go #

Patch Set 4 : diff -r 13e00572ed0b https://code.google.com/p/go/ #

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	src/cmd/ld/lib.c	View	1 2	3 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

minux1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

12 years, 8 months ago (2013-04-19 14:11:19 UTC) #1

minux1

12 years, 8 months ago (2013-04-19 18:44:45 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=6f2e3bc74895 ***

cmd/ld: don't show cursym in gcc invocation failure message
before:
fmt.statictmp_0731:/usr/local/go/pkg/tool/linux_amd64/6l: running gcc failed:
unsuccessful exit status 0x100
now:
/usr/local/go/pkg/tool/linux_amd64/6l: running gcc failed: unsuccessful exit
status 0x100

R=golang-dev, iant, r
CC=golang-dev
https://codereview.appspot.com/8827045

Expand All Messages | Collapse All Messages