Issue 88260043: code review 88260043: go.crypto/ssh/agent: add key type to testAgentInterface

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 88260043: code review 88260043: go.crypto/ssh/agent: add key type to testAgentInterface

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by hanwen-google

Modified:
12 years, 6 months ago

Reviewers:

CC:
agl1, dave_cheney.net, jpsugar, golang-codereviews

Visibility:
Public.

Description

go.crypto/ssh/agent: add key type to testAgentInterface failure messages.

Patch Set 1 #

Patch Set 2 : diff -r d26295c2111a https://hanwen%40google.com@code.google.com/p/go.crypto/ #

Patch Set 3 : diff -r d26295c2111a https://hanwen%40google.com@code.google.com/p/go.crypto/ #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -5 lines)			Patch
	M	ssh/agent/client_test.go	View	1	3 chunks	+4 lines, -5 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

hanwen-google

Hello agl1, dave@cheney.net, jpsugar@google.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://hanwen%40google.com@code.google.com/p/go.crypto/

12 years, 6 months ago (2014-04-15 20:34:54 UTC) #1

agl1

12 years, 6 months ago (2014-04-15 20:48:59 UTC) #2

*** Submitted as
https://code.google.com/p/go/source/detail?r=5478be1963aa&repo=crypto ***

go.crypto/ssh/agent: add key type to testAgentInterface failure messages.

R=agl, dave, jpsugar
CC=golang-codereviews
https://codereview.appspot.com/88260043

Committer: Adam Langley <agl@golang.org>

Expand All Messages | Collapse All Messages