Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3521)

Issue 8825044: Fix back button, hooks select, font sizes in tabs

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by rharding
Modified:
11 years ago
Reviewers:
curtis, mp+160336
Visibility:
Public.

Description

Fix back button, hooks select, font sizes in tabs Fix bugs per UX review. - Fixes #1171500 - back button styling - Fixes #1171522: Hooks - drop down list - show "Select --" as default. Remove text below control. - Fixes #1171524: Change in font size when select a tab https://code.launchpad.net/~rharding/juju-gui/uxbugs-1/+merge/160336 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix back button, hooks select, font sizes in tabs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -6 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
D app/assets/images/browser_add_button_centre.jpg View 0 chunks +-1 lines, --1 lines 0 comments Download
A app/assets/images/browser_add_button_centre.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/browser_add_button_left.jpg View 0 chunks +-1 lines, --1 lines 0 comments Download
A app/assets/images/browser_add_button_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/browser_add_button_right.jpg View 0 chunks +-1 lines, --1 lines 0 comments Download
A app/assets/images/browser_add_button_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A app/assets/images/browser_back_button_arrow.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/browser_back_button_centre.jpg View 0 chunks +-1 lines, --1 lines 0 comments Download
A app/assets/images/browser_back_button_centre.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/browser_back_button_left.jpg View 0 chunks +-1 lines, --1 lines 0 comments Download
A app/assets/images/browser_back_button_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/browser_back_button_right.jpg View 0 chunks +-1 lines, --1 lines 0 comments Download
A app/assets/images/browser_back_button_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A app/assets/images/browser_min_max.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/browser_minimize.jpg View 0 chunks +-1 lines, --1 lines 0 comments Download
M app/subapps/browser/templates/browser_charm.handlebars View 2 chunks +5 lines, -3 lines 0 comments Download
M app/subapps/browser/views/charm.js View 1 chunk +3 lines, -1 line 0 comments Download
M app/templates/browser-search.handlebars View 1 chunk +2 lines, -3 lines 0 comments Download
M app/widgets/charm-search.js View 1 chunk +1 line, -0 lines 0 comments Download
M lib/views/browser/charm-full.less View 3 chunks +30 lines, -11 lines 0 comments Download
M lib/views/browser/main.less View 4 chunks +18 lines, -1 line 0 comments Download
M lib/views/browser/tabview.less View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 4
rharding
Please take a look.
11 years ago (2013-04-23 11:36:18 UTC) #1
rharding
LGTM
11 years ago (2013-04-23 12:01:37 UTC) #2
curtis
This is fine to land, LGTM. I have a few remarks inline that can be ...
11 years ago (2013-04-23 14:21:57 UTC) #3
rharding
11 years ago (2013-04-23 16:14:29 UTC) #4
*** Submitted:

Fix back button, hooks select, font sizes in tabs

Fix bugs per UX review.

- Fixes #1171500 - back button styling
- Fixes #1171522: Hooks - drop down list - show "Select --" as default. Remove
text below control.
- Fixes #1171524: Change in font size when select a tab

R=curtis
CC=
https://codereview.appspot.com/8825044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b