Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1588)

Issue 8824044: Handle service life

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by frankban
Modified:
9 years, 7 months ago
Reviewers:
benji, mp+159356, gary.poster
Visibility:
Public.

Description

Handle service life The Life change included in the juju-core delta stream is now stored in the service model, and used to avoid displaying dying services in the topology view. QA: - bootstrap a juju-core env; - deploy a service; - connect the GUI to the env; - use the GUI to destroy the service; - suddenly refresh (or visit the GUI from another browser tab). At this point, even if the service could be still present in the db, it should not be alive and you should not see it in the topology view. https://code.launchpad.net/~frankban/juju-gui/bug-1169858-life/+merge/159356 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 5

Patch Set 2 : Handle service life #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -4 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M app/models/handlers.js View 1 chunk +1 line, -0 lines 0 comments Download
M app/models/models.js View 1 3 chunks +35 lines, -1 line 0 comments Download
M app/views/topology/service.js View 1 chunk +1 line, -1 line 0 comments Download
M test/test_fakebackend.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/test_model.js View 1 1 chunk +36 lines, -0 lines 0 comments Download
M test/test_model_handlers.js View 4 chunks +6 lines, -2 lines 0 comments Download
M test/test_service_module.js View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 6
frankban
Please take a look.
9 years, 7 months ago (2013-04-17 11:27:22 UTC) #1
benji
This looks good (LGTM). I assume there is going to be a follow-on branch that ...
9 years, 7 months ago (2013-04-17 12:37:59 UTC) #2
gary.poster
Looks good. QAing. https://codereview.appspot.com/8824044/diff/1/app/models/models.js File app/models/models.js (right): https://codereview.appspot.com/8824044/diff/1/app/models/models.js#newcode99 app/models/models.js:99: Return true if this service life ...
9 years, 7 months ago (2013-04-17 12:54:26 UTC) #3
gary.poster
LGTM. QA went well. Thank you! Gary
9 years, 7 months ago (2013-04-17 13:10:16 UTC) #4
frankban
*** Submitted: Handle service life The Life change included in the juju-core delta stream is ...
9 years, 7 months ago (2013-04-17 13:39:01 UTC) #5
frankban
9 years, 7 months ago (2013-04-17 13:49:09 UTC) #6
Thank you both for the reviews!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b