Issue 8823043: state: start allManager on demand

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8823043: state: start allManager on demand

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by rog

Modified:
11 years ago

Reviewers:
mp+159337, fwereade

Visibility:
Public.

Description

state: start allManager on demand As things are currently, every single agent will be watching *everything*. This is clearly wrong, so we start the allManager only when someone wants to watch everything. https://code.launchpad.net/~rogpeppe/juju-core/291-allwatcher-on-demand/+merge/159337 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state: start allManager on demand #

Patch Set 3 : state: start allManager on demand #

Patch Set 4 : state: start allManager on demand #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -4 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/open.go	View	3 chunks	+6 lines, -3 lines	0 comments	Download
M	state/state.go	View	2 chunks	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rog

11 years ago (2013-04-17 10:14:46 UTC) #3

*** Submitted:

state: start allManager on demand

As things are currently, every single agent
will be watching *everything*. This is clearly
wrong, so we start the allManager only
when someone wants to watch everything.

R=fwereade
CC=
https://codereview.appspot.com/8823043

Expand All Messages | Collapse All Messages