Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(178)

Issue 8821046: code review 8821046: misc/dashboard/builder: include $USER in build environment. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 5 months ago by dsymonds
Modified:
9 years, 5 months ago
Reviewers:
lucio
CC:
golang-dev, r
Visibility:
Public.

Description

misc/dashboard/builder: include $USER in build environment.

Patch Set 1 #

Patch Set 2 : diff -r 522c34c6fe61 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 522c34c6fe61 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r dda87c8bcba1 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M misc/dashboard/builder/main.go View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5
dsymonds
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
9 years, 5 months ago (2013-04-18 00:22:07 UTC) #1
r
LGTM although it shouldn't be necessary.
9 years, 5 months ago (2013-04-18 00:38:48 UTC) #2
dsymonds
On Thu, Apr 18, 2013 at 10:38 AM, <r@golang.org> wrote: > LGTM although it shouldn't ...
9 years, 5 months ago (2013-04-18 01:02:43 UTC) #3
dsymonds
*** Submitted as https://code.google.com/p/go/source/detail?r=e974430a6f67 *** misc/dashboard/builder: include $USER in build environment. R=golang-dev, r CC=golang-dev https://codereview.appspot.com/8821046
9 years, 5 months ago (2013-04-18 01:04:29 UTC) #4
lucio
9 years, 5 months ago (2013-04-18 04:13:06 UTC) #5
On 4/18/13, David Symonds <dsymonds@golang.org> wrote:
> On Thu, Apr 18, 2013 at 10:38 AM,  <r@golang.org> wrote:
>
>> LGTM although it shouldn't be necessary.
>
> It does seem to be if cgo is disabled and you want the os/user package to
> work.
>
I had noted that when running tests for Plan 9 (386 or ARM), but at
this point that was not enough cause to investigate (and Gorka did not
report the same error).  I'll look into it, because it seems to me to
be an error in os/user rather than a missing environment variable.

I won't create an issue without investigating further, maybe someone
else wants to do that before I do?

Lucio.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b