Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1498)

Issue 8821043: state: lose misleading log messages

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by rog
Modified:
9 years, 7 months ago
Reviewers:
dimitern, mp+159315, fwereade
Visibility:
Public.

Description

state: lose misleading log messages https://code.launchpad.net/~rogpeppe/juju-core/290-state-less-logging/+merge/159315 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state: lose misleading log messages #

Patch Set 3 : state: lose misleading log messages #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M state/megawatcher.go View 1 2 4 chunks +0 lines, -4 lines 0 comments Download
M state/unit.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
rog
Please take a look.
9 years, 7 months ago (2013-04-17 09:31:46 UTC) #1
fwereade
LGTM trivial
9 years, 7 months ago (2013-04-17 13:42:18 UTC) #2
dimitern
LGTM
9 years, 7 months ago (2013-04-18 08:40:06 UTC) #3
rog
9 years, 7 months ago (2013-04-18 11:03:56 UTC) #4
*** Submitted:

state: lose misleading log messages

R=fwereade, dimitern
CC=
https://codereview.appspot.com/8821043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b