code review 8820043: go.crypto/ssh/test: Fix distracting nil pointer derefer...

go.crypto/ssh/test: Fix distracting nil pointer dereference in a test.

If cgo is disabled (such as it appears to be on a subset of builders),
username() panics, and s.cmd is nil; let's not panic while recovering
from a different panic.

[dsymonds, 2013-04-17 07:34:42]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go.crypto

[dfc, 2013-04-17 07:39:45]

LGTM. Thanks for taking care of these. 

On 17/04/2013, at 17:34, dsymonds@golang.org wrote:

> Reviewers: golang-dev1,
> 
> Message:
> Hello golang-dev@googlegroups.com,
> 
> I'd like you to review this change to
> https://code.google.com/p/go.crypto
> 
> 
> Description:
> go.crypto/ssh/test: Fix distracting nil pointer dereference in a test.
> 
> If cgo is disabled (such as it appears to be on a subset of builders),
> username() panics, and s.cmd is nil; let's not panic while recovering
> from a different panic.
> 
> Please review this at https://codereview.appspot.com/8820043/
> 
> Affected files:
>  M ssh/test/test_unix_test.go
> 
> 
> Index: ssh/test/test_unix_test.go
> ===================================================================
> --- a/ssh/test/test_unix_test.go
> +++ b/ssh/test/test_unix_test.go
> @@ -128,7 +128,7 @@
> }
> 
> func (s *server) Shutdown() {
> -    if s.cmd.Process != nil {
> +    if s.cmd != nil && s.cmd.Process != nil {
>        if err := s.cmd.Process.Kill(); err != nil {
>            s.t.Error(err)
>        }
> 
> 
> -- 
> 
> ---You received this message because you are subscribed to the Google Groups
"golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
> 
> 

[dsymonds, 2013-04-17 07:40:39]

*** Submitted as
https://code.google.com/p/go/source/detail?r=2a558d1ad724&repo=crypto ***

go.crypto/ssh/test: Fix distracting nil pointer dereference in a test.

If cgo is disabled (such as it appears to be on a subset of builders),
username() panics, and s.cmd is nil; let's not panic while recovering
from a different panic.

R=golang-dev, dave
CC=golang-dev
https://codereview.appspot.com/8820043