code review 8817043: go.crypto/ssh/test: improve diagnostics for test failin...

go.crypto/ssh/test: improve diagnostics for test failing to get username.

[dsymonds, 2013-04-17 04:26:16]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go.crypto

[dave_cheney.net, 2013-04-17 05:56:58]

LGTM. Thank you.

On Wed, Apr 17, 2013 at 2:26 PM,  <dsymonds@golang.org> wrote:
> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go.crypto
>
>
> Description:
> go.crypto/ssh/test: improve diagnostics for test failing to get
> username.
>
> Please review this at https://codereview.appspot.com/8817043/
>
> Affected files:
>   M ssh/test/test_unix_test.go
>
>
> Index: ssh/test/test_unix_test.go
> ===================================================================
> --- a/ssh/test/test_unix_test.go
> +++ b/ssh/test/test_unix_test.go
> @@ -18,6 +18,7 @@
>         "errors"
>         "io"
>         "io/ioutil"
> +       "log"
>         "net"
>         "os"
>         "os/exec"
> @@ -79,6 +80,7 @@
>         } else {
>                 // user.Current() currently requires cgo. If an error is
>                 // returned attempt to get the username from the
> environment.
> +               log.Printf("user.Current: %v; falling back on $USER", err)
>                 username = os.Getenv("USER")
>         }
>         if username == "" {
>
>
> --
>
> ---You received this message because you are subscribed to the Google Groups
> "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>

[dsymonds, 2013-04-17 06:22:48]

*** Submitted as
https://code.google.com/p/go/source/detail?r=3fb6a89b4ee1&repo=crypto ***

go.crypto/ssh/test: improve diagnostics for test failing to get username.

R=golang-dev, dave
CC=golang-dev
https://codereview.appspot.com/8817043