Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(151)

Issue 88130046: code review 88130046: build: disable static cgo linking test on netbsd (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by rsc
Modified:
11 years, 6 months ago
Reviewers:
iant
CC:
golang-codereviews
Visibility:
Public.

Description

build: disable static cgo linking test on netbsd We get /usr/lib/libc.a(stack_protector.o): In function `__stack_chk_fail_local': stack_protector.c:(.text+0x158): multiple definition of `__stack_chk_fail_local' /var/tmp/go-link-04838a/000001.o:/tmp/gobuilder/netbsd-386-minux-c7a9e9243878/go/src/pkg/runtime/cgo/gcc_386.S:41: first defined here I am assuming this has never worked and possibly is not intended to work. (Some systems are vehemently against static linking.)

Patch Set 1 #

Patch Set 2 : diff -r c7a9e9243878 https://code.google.com/p/go/ #

Patch Set 3 : diff -r c7a9e9243878 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M src/run.bash View 1 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 3
rsc
Hello iant (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
11 years, 6 months ago (2014-04-15 19:52:00 UTC) #1
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=5db28b080054 *** build: disable static cgo linking test on netbsd We get ...
11 years, 6 months ago (2014-04-15 19:52:07 UTC) #2
iant
11 years, 6 months ago (2014-04-15 19:56:17 UTC) #3
Message was sent while issue was closed.
LGTM

I don't think "no static linking" is really the issue, but it doesn't matter
much.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b