Issue 88130: Add move,pitch, and yaw functions to mlab.py

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 88130: Add move,pitch, and yaw functions to mlab.py

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 9 months ago by etollerud

Modified:
9 years, 4 months ago

Reviewers:
prabhu

Base URL:
https://svn.enthought.com/svn/enthought/Mayavi/trunk/

Visibility:
Public.

Description

As per the discussion on the mailing list (https://mail.enthought.com/pipermail/enthought-dev/2009-July/022430.html) here is a diff against the current svn to add move,pitch, and yaw functions to mayavi's mlab interface.

Patch Set 1 #

Total comments: 2

Created: 14 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+174 lines, -0 lines)			Patch
		enthought/mayavi/tools/camera.py	View		1 chunk	+174 lines, -0 lines	2 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

prabhu

14 years, 9 months ago (2009-07-09 02:18:02 UTC) #2

This is excellent, I'll check this in shortly. I've made some minor comments for
your information, no need to submit a modified patch.

http://codereview.appspot.com/88130/diff/1/2
File enthought/mayavi/tools/camera.py (right):

http://codereview.appspot.com/88130/diff/1/2#newcode184
Line 184: def move(forward=None,right=None,up=None):
Please leave a space after every argument, i.e. forward=None, right=None,
up=None.

http://codereview.appspot.com/88130/diff/1/2#newcode187
Line 187: move(forward=None,right=None,up=None)
This is not necessary, ipython and others usually provide the function signature
in the documentation.

Expand All Messages | Collapse All Messages