Issue 88095: get_vtk_src

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 88095: get_vtk_src (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 10 months ago by Gael.Varoquaux

Modified:
14 years, 4 months ago

Reviewers:
prabhu

Base URL:
https://svn.enthought.com/svn/enthought/Mayavi/trunk/

Visibility:
Public.

Description

refactor find_data to get_vtk_src, and expose it.

Patch Set 1 #

Total comments: 4

Created: 14 years, 10 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+38 lines, -31 lines)			Patch
enthought/mayavi/tools/helper_functions.py	View	1 chunk	+2 lines, -2 lines	0 comments	Download
enthought/mayavi/tools/pipeline.py	View	1 chunk	+2 lines, -1 line	0 comments	Download
enthought/mayavi/tools/tools.py	View	4 chunks	+34 lines, -28 lines	4 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

prabhu

14 years, 9 months ago (2009-07-07 17:00:44 UTC) #3

Thanks for the patch, looks OK except for my comments.  Please address those and
checkin.  Thanks.

http://codereview.appspot.com/88095/diff/1/4
File enthought/mayavi/tools/tools.py (right):

http://codereview.appspot.com/88095/diff/1/4#newcode108
Line 108: def get_vtk_src(mayavi_object, filter_ok=True):
I don't like "filter_ok", "stop_at_filter" sounds better.

http://codereview.appspot.com/88095/diff/1/4#newcode116
Line 116: :filter_ok: optionnal boolean flag: if True, the first object
spelling: optional

http://codereview.appspot.com/88095/diff/1/4#newcode128
Line 128: This function traverses the Mayavi pipeline. Thus the input
please clarify what you mean by "the input object" by referring to the
`mayavi_object`.

http://codereview.appspot.com/88095/diff/1/4#newcode133
Line 133: raise TypeError, 'Cannot find data source for given object'
Perhaps the error message can be
'Cannot find data source for given %s'%(mayavi_object)
or something more informative.

Expand All Messages | Collapse All Messages