Minor changes in wifi module needed by 802.11s

[Andrey Mazo, 2009-07-06 04:55:51]

Proposed fix for bug 381.

http://codereview.appspot.com/88093/diff/1/2
File src/devices/wifi/mac-low.cc (right):

http://codereview.appspot.com/88093/diff/1/2#newcode274
Line 274: m_listener = 0;
This change is proposed here:
http://www.nsnam.org/bugzilla/show_bug.cgi?id=381

[Mathieu Lacage, 2009-07-13 12:38:07]

http://codereview.appspot.com/88093/diff/1/2
File src/devices/wifi/mac-low.cc (right):

http://codereview.appspot.com/88093/diff/1/2#newcode274
Line 274: m_listener = 0;
I will look at the bug report separately.

http://codereview.appspot.com/88093/diff/1/5
File src/devices/wifi/wifi-mac-header.cc (right):

http://codereview.appspot.com/88093/diff/1/5#newcode942
Line 942: // TODO
as you say, TODO before merging :)

same for 2 items below

[Pavel Boyko, 2009-07-14 06:08:30]

Cosmetics done, new patch set including minor changes in qos* uploaded.

http://codereview.appspot.com/88093/diff/1/5
File src/devices/wifi/wifi-mac-header.cc (right):

http://codereview.appspot.com/88093/diff/1/5#newcode942
Line 942: // TODO
On 2009/07/13 12:38:09, Mathieu Lacage wrote:
> as you say, TODO before merging :)
> 
> same for 2 items below

Done.

[Mathieu Lacage, 2009-07-15 19:04:42]

ok for me to commit everything except for the 2 small items I commented on

http://codereview.appspot.com/88093/diff/21/22
File src/devices/wifi/mac-low.cc (right):

http://codereview.appspot.com/88093/diff/21/22#newcode274
Line 274: m_listener = 0;
please, wait until bug 381 is resolved separately

http://codereview.appspot.com/88093/diff/21/27
File src/devices/wifi/qos-utils.cc (right):

http://codereview.appspot.com/88093/diff/21/27#newcode30
Line 30: return AC_BE;
this is change does not fix anything: it's merely a style change. Can you leave
this out ?

[Pavel Boyko, 2009-07-16 05:33:28]

http://codereview.appspot.com/88093/diff/21/22
File src/devices/wifi/mac-low.cc (right):

http://codereview.appspot.com/88093/diff/21/22#newcode274
Line 274: m_listener = 0;
On 2009/07/15 19:04:42, Mathieu Lacage wrote:
> please, wait until bug 381 is resolved separately

Done.

http://codereview.appspot.com/88093/diff/21/27
File src/devices/wifi/qos-utils.cc (right):

http://codereview.appspot.com/88093/diff/21/27#newcode30
Line 30: return AC_BE;
On 2009/07/15 19:04:42, Mathieu Lacage wrote:
> this is change does not fix anything: it's merely a style change. Can you
leave
> this out ?

Done.

[Pavel Boyko, 2009-07-16 12:49:02]

pushed to mainline.