code review 88090045: runtime: adjust GC debug print to include source pointers

runtime: adjust GC debug print to include source pointers

Having the pointers means you can grub around in the
binary finding out more about them.

This helped with issue 7748.

[rsc, 2014-04-16 04:19:22]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[minux1, 2014-04-16 04:22:38]

LGTM.

[bradfitz, 2014-04-16 04:22:59]

LGTM
 On Apr 15, 2014 9:19 PM, <rsc@golang.org> wrote:

> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> runtime: adjust GC debug print to include source pointers
>
> Having the pointers means you can grub around in the
> binary finding out more about them.
>
> This helped with issue 7748.
>
> Please review this at https://codereview.appspot.com/88090045/
>
> Affected files (+2, -2 lines):
>   M src/pkg/runtime/mgc0.c
>
>
> Index: src/pkg/runtime/mgc0.c
> ===================================================================
> --- a/src/pkg/runtime/mgc0.c
> +++ b/src/pkg/runtime/mgc0.c
> @@ -702,8 +702,8 @@
>                 // A simple best-effort check until first GC_END.
>                 for(j = 1; pc1[j] != GC_END && pc2[j] != GC_END; j++) {
>                         if(pc1[j] != pc2[j]) {
> -                               runtime·printf("invalid gc type info for
> '%s' at %p, type info %p, block info %p\n",
> -                                              t->string ?
> (int8*)t->string->str : (int8*)"?", j, pc1[j], pc2[j]);
> +                               runtime·printf("invalid gc type info for
> '%s', type info %p [%d]=%p, block info %p [%d]=%p\n",
> +                                              t->string ?
> (int8*)t->string->str : (int8*)"?", pc1, (int32)j, pc1[j], pc2, (int32)j,
> pc2[j]);
>                                 runtime·throw("invalid gc type info");
>                         }
>                 }
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[rsc, 2014-04-16 15:39:50]

*** Submitted as https://code.google.com/p/go/source/detail?r=771a1c388e7a ***

runtime: adjust GC debug print to include source pointers

Having the pointers means you can grub around in the
binary finding out more about them.

This helped with issue 7748.

LGTM=minux.ma, bradfitz
R=golang-codereviews, minux.ma, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/88090045