Issue 88080048: code review 88080048: compiler: Define immutability for numeric, constant, ty...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 88080048: code review 88080048: compiler: Define immutability for numeric, constant, ty...

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years ago by cmang

Modified:
10 years ago

Reviewers:
iant

CC:
iant, gofrontend-dev_googlegroups.com

Visibility:
Public.

Description

compiler: Define immutability for numeric, constant, type info, type conversion, and addressof expressions.

Patch Set 1 #

Patch Set 2 : diff -r 194e0f47c9e5 https://code.google.com/p/gofrontend #

Patch Set 3 : diff -r 194e0f47c9e5 https://code.google.com/p/gofrontend #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -1 line)			Patch
	M	go/expressions.cc	View	1	10 chunks	+54 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

cmang

Hello iant@golang.org (cc: gofrontend-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/gofrontend

10 years ago (2014-04-17 17:12:58 UTC) #1

iant

10 years ago (2014-04-17 19:09:41 UTC) #3

*** Submitted as
https://code.google.com/p/gofrontend/source/detail?r=43e2635914c2 ***

compiler: Define immutability for numeric, constant, type info, type conversion,
and addressof expressions.

R=iant
CC=gofrontend-dev
https://codereview.appspot.com/88080048

Committer: Ian Lance Taylor <iant@golang.org>

Expand All Messages | Collapse All Messages